[Kamailio-Users] NAThelper and multipart SDP

[Pascal Maugeri]

Yes, you're right. Sorry for that.
-pascal

On Mon, Jun 22, 2009 at 1:52 PM, Daniel-Constantin Mierla <miconda at gmail.com
> wrote:

>
>
> On 06/22/2009 01:46 PM, Pascal Maugeri wrote:
>
>> If I understood correctly you want me to test the patch nhelpr_func.c
>> you've done in sr in kamailio ?
>> This is what I've done and at least it compiles :-)
>>
>> (I also tried to compile sr, but I need to sudy it a bit more as I've
>> never installed sr so far)
>>
>> Nevertheless, the ouput payload is wrong:
>>
>> Content-Type: application/sdp
>>
>> v=0
>> o=- 3454665275 3454665275 IN IP4 10.1.1.248
>> s=pjmedia
>> c=IN IP4 88.29.163.14288.29.163.142
>> t=0 0
>> a=X-nat:0
>> m=audio 5191251912 RTP/AVP 115
>> [...]
>> m=application 4198041980 udp TBCP
>>
>> The RTP and RTCP ports are wrong: 5191251912 and 4198041980  ?!
>>
>> Where could I have a look in nathelper source to see what is wrong ?
>>
>
> it seems you call force_rtp_rpoxy() twice, as you get the port two times as
> well as the ip address. Check your config.
>
> Cheers,
> Daniel
>
>
>> -pascal
>>
>>
>>
>>
>>
>>
>> On Mon, Jun 22, 2009 at 11:36 AM, Daniel-Constantin Mierla <
>> miconda at gmail.com <mailto:miconda at gmail.com>> wrote:
>>
>>    Hello Pascal,
>>
>>    I have just committed support for multipart bodies in sip router,
>>    if works then I will backport to 1.5.
>>
>>
>> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1f41271e1c1b879217835b8b3fdbdc2680138f25
>>
>>
>>    Can you test it? Unfortunately I cannot do it these days properly
>>    due to traveling. Patch should work pretty straightforward with
>>    1.5 though, if you want to test it directly there.
>>
>>    Cheers,
>>    Daniel
>>
>>
>>    On 06/22/2009 11:30 AM, Pascal Maugeri wrote:
>>
>>        I tried to install mediaproxy but it looks tricky to install
>>        (many dependencies, including kernel specific configurations) :-(
>>        and I would like to stick to rtpproxy for performance reason.
>>
>>        Do you believe the same workaround using textops/filter_body
>>        can be used using rtpproxy ? I think yes as these are two
>>        different things as said Juha.
>>
>>        Regards,
>>        Pascal
>>
>>
>>        On Fri, Jun 19, 2009 at 9:26 PM, Pascal Maugeri
>>        <pascal.maugeri at gmail.com <mailto:pascal.maugeri at gmail.com>
>>        <mailto:pascal.maugeri at gmail.com
>>        <mailto:pascal.maugeri at gmail.com>>> wrote:
>>
>>
>>
>>           On Fri, Jun 19, 2009 at 9:13 PM, Juha Heinanen
>>        <jh at tutpro.com <mailto:jh at tutpro.com>
>>           <mailto:jh at tutpro.com <mailto:jh at tutpro.com>>> wrote:
>>
>>               Pascal Maugeri writes:
>>
>>                > So if I understand well (please correct me if I'm wrong)
>>               the "plan" is:
>>                >
>>                > 1º) I install MediaProxy and use Kamailio MEDIAPROXY
>>        module
>>               instead of
>>                > rtpproxy/NATHelper
>>                >
>>                > 2º) filter the app/sdp part with
>>                >
>>                > if (has_body("multipart/mixed")) {
>>                >     if (filter_body("application/sdp") {
>>                >         remove_hf("Content-Type");
>>                >
>>                >         append_hf("Content-Type: application/sdp\r\n");
>>                >     } else {
>>                >
>>                >         xlog("Body part application/sdp not found\n");
>>                >     }
>>                > }
>>
>>               you don't need to call filter_body if you use mediaproxy.
>>
>>                > 3º) then engage the media proxy with
>>                >
>>                > if (method==INVITE && !has_totag()) {
>>                >
>>                >     # We can also use a specific media relay if we
>>        need to
>>                >     #$avp(s:media_relay) = "1.2.3.4";
>>                >     engage_media_proxy();
>>                > }
>>
>>               i have never used engage_media_proxy() functions,
>>        because it
>>               makes some
>>               assumptions that are not generally true.  i use
>>               use_media_proxy() instead.
>>
>>                > 4º) finally put the body part(s) that have been
>>        removed in
>>               1º) and relay the
>>                > INVITE to my next hop.
>>                >      I believe I can save the body part(s) in 1º)
>>        and put
>>               them back using
>>                > set_body(txt, content_type).
>>
>>               you don't need to do anything like that if you use
>>               use_media_proxy()
>>               function, because it does not remove anything.
>>
>>
>>           Thanks Juha ! I can't wait for monday to test it :-)
>>
>>           Have a nice week-end
>>           Pascal
>>
>>
>>               -- juha
>>
>>
>>
>>
>>  ------------------------------------------------------------------------
>>
>>        _______________________________________________
>>        Kamailio (OpenSER) - Users mailing list
>>        Users at lists.kamailio.org <mailto:Users at lists.kamailio.org>
>>        http://lists.kamailio.org/cgi-bin/mailman/listinfo/users
>>        http://lists.openser-project.org/cgi-bin/mailman/listinfo/users
>>
>>
>>    --    Daniel-Constantin Mierla
>>    http://www.asipto.com/
>>
>>
>>
> --
> Daniel-Constantin Mierla
> http://www.asipto.com/
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-users/attachments/20090622/f5354657/attachment.htm>