[OpenSER-Users] LCR module allows "q" value > 1.00
Juha Heinanen
jh at tutpro.com
Sat Oct 27 18:36:50 CEST 2007
Iñaki Baz Castillo writes:
> LCR next_contacts() function allows these "extrange" values and
> respect them (contact with "q" = 50.00 is called before contact with
> "q" = 2.00).
>
> This is not exactly a bug since it's an human error to set an entry
> in "location" table with "q" value greater than 1.00, but maybe LCR module
> could ignore values grater than 1.00 and assume 1.00 in these cases?
load_contacts just takes q value from branch struct. the right place to
fix this is in usrloc module. it should check that q value read from
location has a valid value and discard invalid entries. changing an
illegal value to a legal one is not a good idea.
-- juha
More information about the sr-users
mailing list