[Serusers] SER rel 2_0_0 - Errors in msilo module

[Vaclav Kubart]

Tomasz, 
it is strange, but it works for me without any patches. Please, could
you send me your msilo module parameters?

	thanks

		Vaclav


On Wed, May 16, 2007 at 10:28:29AM +0200, tzieleniewski wrote:
> Thanks michal,
> 
> I did it and it worked 
> after patch there appeared an analogous error in the m_dump(..) function in the msilo.c I made the similar correction and now everything works fine.
> I attached my patch for both things:)
> 
> Cheers
> tomasz
> 
> > Hi,
> > try run patch with one more parameter -l (or --ignore-whitespace). 
> > I will attach the patch instead putting it inline next time.
> > 
> > Michal
> > 
> > On St, 2007-05-16 at 09:56 +0200, tzieleniewski wrote:
> > > Hi michal,
> > > 
> > > I run the following patch but there was an error, can you please take a look.
> > > my output below:
> > > 
> > > ser at sen:~/src/ser-2.0/modules/msilo$ patch -p0 msilo.c < msilo.c.patch
> > > patching file msilo.c
> > > Hunk #1 FAILED at 325.
> > > 1 out of 1 hunk FAILED -- saving rejects to file msilo.c.rej
> > > ser at sen:~/src/ser-2.0/modules/msilo$ cat msilo.c.patch
> > > --- msilo.c     Mon May 14 15:28:46 2007 +0200
> > > +++ msilo.c     Mon May 14 17:22:27 2007 +0200
> > > @@ -325,9 +325,9 @@
> > >                 goto error;
> > >         }
> > >         mode = str1[0] - '0';
> > > -       if (str2) {
> > > +       next_hop.len = strlen(str2);
> > > +       if (next_hop.len) {
> > >                 next_hop.s = str2;
> > > -               next_hop.len = strlen(str2);
> > >         }
> > > 
> > >         if (get_to_uid(&uid, msg) < 0) {
> > > 
> > > Cheers tomasz
> > > 
> > > > You can try apply patch like this:
> > > > diff -r f576f4aff98e modules/msilo/msilo.c
> > > > --- a/modules/msilo/msilo.c     Mon May 14 15:28:46 2007 +0200
> > > > +++ b/modules/msilo/msilo.c     Mon May 14 17:22:27 2007 +0200
> > > > @@ -325,9 +325,9 @@ static int m_store(struct sip_msg* msg, 
> > > >                 goto error;
> > > >         }
> > > >         mode = str1[0] - '0';
> > > > -       if (str2) {
> > > > +       next_hop.len = strlen(str2);
> > > > +       if (next_hop.len) {
> > > >                 next_hop.s = str2;
> > > > -               next_hop.len = strlen(str2);
> > > >         }
> > > >  
> > > >         if (get_to_uid(&uid, msg) < 0) {
> > > > 
> > > > And please fill bug report at tracker.
> > > > Michal
> > > > 
> > > > On Po, 2007-05-14 at 15:35 +0200, tzieleniewski wrote:
> > > > > Hi,
> > > > > 
> > > > > When I try to store message in the database I get the following errors in the syslog (There are no messages stored in the database):
> > > > > 
> > > > > May 14 15:26:40 sen ser[5853]: ERROR: parse_uri: uri too short: <> (0)
> > > > > May 14 15:26:40 sen ser[5853]: ERROR: uri2dst: bad_uri:
> > > > > May 14 15:26:40 sen ser[5853]: t_uac: no socket found
> > > > > 
> > > > > And here is ser.cfg:
> > > > > xlog("L_INFO", " route[INBOUND]: (m_store (0, )) \n");
> > > > > if (m_store ("0", ""))
> > > > > {
> > > > >   xlog("L_INFO", " route[INBOUND]: offline message stored \n");
> > > > >   xlog("L_INFO", " route[INBOUND]: (!t_reply(202,Accepted) \n");
> > > > >   if (!t_reply("202", "Accepted"))
> > > > >   {
> > > > >    xlog("L_INFO", " route[INBOUND]: sl_reply_error() \n");
> > > > >    sl_reply_error();
> > > > >   }
> > > > > }
> > > > > 
> > > > > the error appears in the following place accordin to my logging:
> > > > > May 14 15:26:40 sen ser[5853]:  route[INBOUND]: (m_store (0, ))
> > > > > May 14 15:26:40 sen ser[5853]: ERROR: parse_uri: uri too short: <> (0)
> > > > > May 14 15:26:40 sen ser[5853]: ERROR: uri2dst: bad_uri:
> > > > > May 14 15:26:40 sen ser[5853]: t_uac: no socket found
> > > > > May 14 15:26:40 sen ser[5853]:  route[INBOUND]: offline message stored
> > > > > May 14 15:26:40 sen ser[5853]:  route[INBOUND]: (!t_reply(202,Accepted)
> > > > > May 14 15:26:40 sen ser[5853]:  route[INBOUND]: drop <MESSAGE> <sip:hulk at voip.rd.touk.pl>
> > > > > 
> > > > > Below is the Message transaction sent through SER:
> > > > > 
> > > > > U 2007/05/14 15:26:40.746835 192.168.0.165:7089 -> 192.168.0.165:5060
> > > > > MESSAGE sip:hulk at voip.rd.touk.pl SIP/2.0.
> > > > > CSeq: 64 MESSAGE.
> > > > > Via: SIP/2.0/UDP 192.168.0.165:7089;branch=z9hG4bK24d4276b-8c00-dc11-982b-00148539376e;rport.
> > > > > From: "Sen" <sip:sen at voip.rd.touk.pl>;tag=a0d0276b-8c00-dc11-982b-00148539376e.
> > > > > Call-ID: 32c6276b-8c00-dc11-982b-00148539376e at sen.
> > > > > To: "hulk@" <sip:hulk at voip.rd.touk.pl>.
> > > > > Allow: INVITE,ACK,OPTIONS,BYE,CANCEL,NOTIFY,REFER,MESSAGE.
> > > > > Content-Type: text/plain;charset=UTF-8.
> > > > > Content-Length: 12.
> > > > > Max-Forwards: 70.
> > > > > .
> > > > > test message
> > > > > #
> > > > > U 2007/05/14 15:26:40.790793 192.168.0.165:5060 -> 192.168.0.165:7089
> > > > > SIP/2.0 202 Accepted.
> > > > > CSeq: 64 MESSAGE.
> > > > > Via: SIP/2.0/UDP 192.168.0.165:7089;branch=z9hG4bK24d4276b-8c00-dc11-982b-00148539376e;rport=7089.
> > > > > From: "Sen" <sip:sen at voip.rd.touk.pl>;tag=a0d0276b-8c00-dc11-982b-00148539376e.
> > > > > Call-ID: 32c6276b-8c00-dc11-982b-00148539376e at sen.
> > > > > To: "hulk@" <sip:hulk at voip.rd.touk.pl>;tag=a6a1c5f60faecf035a1ae5b6e96e979a-fd05.
> > > > > Server: Sip EXpress router (2.0.0-rc1 (x86_64/linux)).
> > > > > Content-Length: 0.
> > > > > Warning: 392 192.168.0.165:5060 "Noisy feedback tells:  pid=5853 req_src_ip=192.168.0.165 req_src_port=7089 in_uri=sip:hulk at voip.rd.touk.pl out_uri=sip:hulk at voip.rd.touk.pl via_cnt==1".
> > > > > .
> > > > > 
> > > > > Thanks for any feedback!
> > > > > Cheers
> > > > > Tomasz
> > > > > 
> > > > >  
> > > > > _______________________________________________
> > > > > Serusers mailing list
> > > > > Serusers at lists.iptel.org
> > > > > http://lists.iptel.org/mailman/listinfo/serusers
> > > > 
> > 


> _______________________________________________
> Serusers mailing list
> Serusers at lists.iptel.org
> http://lists.iptel.org/mailman/listinfo/serusers