[OpenSER-Users] uac_replace_from issues

[Alex Hermann]

Hello,

I have 2 issues with uac_replace_from.

1) Can someone add a big fat warning to the documentation 
that "append_fromtag" from the rr module MUST be enabled for automatic 
restore to function? I got random memory locations copied into the To: or 
From: header when it was disabled.


2) I get the message "ERROR:uac:restore_from: new URI shorter than old URI". 

Is there a limitation to what I can replace or what it can be replaced with? 

Can I safely remove this limitation in modules/uac/from.c ?

diff -ru openser-1.2-orig/modules/uac/from.c openser-1.2/modules/uac/from.c
--- openser-1.2-orig/modules/uac/from.c 2007-10-22 11:48:48.000000000 +0200
+++ openser-1.2/modules/uac/from.c      2007-12-04 17:20:44.000000000 +0100
@@ -472,10 +472,6 @@
        }

        /* get new uri */
-       if ( new_uri.len<old_uri.len ) {
-               LOG(L_ERR,"ERROR:uac:restore_from: new URI shorter than old 
URI\n");
-               goto failed;
-       }
        for( i=0 ; i<old_uri.len ; i++ )
                new_uri.s[i] ^= old_uri.s[i];
        if (new_uri.len==old_uri.len) {

	if ( new_uri.len<old_uri.len ) {
		LOG(L_ERR,"ERROR:uac:restore_from: new URI shorter than old URI\n");
		goto failed;
	}

-- 
Greetings,

Alex Hermann