[Serusers] RPID problem in 0.9.0 release

[Francesco Bottà]

Hi all,

I've tested the patch in the 0.9.0 release and now the function append_rpid_hd works great.

Many thanks,

Verbal
----- Original Message ----- 
From: "Richard" <richard at o-matrix.org>
To: <Daniel-Constantin.Mierla at fokus.fraunhofer.de>; "'Francesco Bottà'" <francesco.botta at eutelia.it>
Cc: <serusers at lists.iptel.org>; "'Maxim Sobolev'" <sobomax at portaone.com>
Sent: Tuesday, December 28, 2004 3:51 AM
Subject: RE: [Serusers] RPID problem in 0.9.0 release




> -----Original Message-----
> From: serusers-bounces at iptel.org [mailto:serusers-bounces at lists.iptel.org] On
> Behalf Of Daniel-Constantin.Mierla at fokus.fraunhofer.de
> Sent: Monday, December 27, 2004 8:01 AM
> To: Francesco Bottà
> Cc: serusers at lists.iptel.org; Maxim Sobolev
> Subject: Re: [Serusers] RPID problem in 0.9.0 release
> 
> auth_db is one of the module which wasn't reviewed yet - reason to have a
> prelease (or testing release) by now. As far as I understood, with these
> two
> new parameters you load the values of the appropriate columns from
> database in
> AVP list, while append_rpid_hf() uses a static buffer which is filled when
> use_rpid=1. So you have to keep the value to 1 for now.

It appears to be a bug in the auth_db module. It saves rpid in the static
buffer as well as the avp rpid. The problem is the static buffer refers to a
local variable which probably no longer exists when append_rpid_hf() is
called.

Apply the attached patch should solve the problem.

> Otherwise, you can push a value from AVP list to a header using avpops
> module.
> 
The current avp functions can't manipulate the avp. So prefix and suffix
can't be added to the header field. Of course one can change the data in the
database, but it will not be backward compatible to the existing system.

Richard