[sr-dev] git:master:023af516: acc_json: moved global vars declaration to .c file

Daniel-Constantin Mierla miconda at gmail.com
Fri Sep 23 09:29:47 CEST 2022


Module: kamailio
Branch: master
Commit: 023af516f4ede3742f2e1836474978b596a4a3a8
URL: https://github.com/kamailio/kamailio/commit/023af516f4ede3742f2e1836474978b596a4a3a8

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2022-09-22T20:30:52+02:00

acc_json: moved global vars declaration to .c file

- made them static

---

Modified: src/modules/acc_json/acc_json_mod.c
Modified: src/modules/acc_json/acc_json_mod.h

---

Diff:  https://github.com/kamailio/kamailio/commit/023af516f4ede3742f2e1836474978b596a4a3a8.diff
Patch: https://github.com/kamailio/kamailio/commit/023af516f4ede3742f2e1836474978b596a4a3a8.patch

---

diff --git a/src/modules/acc_json/acc_json_mod.c b/src/modules/acc_json/acc_json_mod.c
index accd054de6..ab6f9b4498 100644
--- a/src/modules/acc_json/acc_json_mod.c
+++ b/src/modules/acc_json/acc_json_mod.c
@@ -37,6 +37,26 @@
 
 MODULE_VERSION
 
+static str acc_method_key = str_init("method");
+static str acc_fromtag_key = str_init("from_tag");
+static str acc_totag_key = str_init("to_tag");
+static str acc_callid_key = str_init("callid");
+static str acc_sipcode_key = str_init("sip_code");
+static str acc_sipreason_key = str_init("sip_reason");
+static str acc_time_key = str_init("time");
+
+static str cdr_start_str = str_init("start_time");
+static str cdr_end_str = str_init("end_time");
+static str cdr_duration_str = str_init("duration");
+
+static char acc_time_format_buf[ACC_TIME_FORMAT_SIZE];
+static char *acc_time_format = "%Y-%m-%d %H:%M:%S";
+
+static int acc_log_level = L_NOTICE;
+static int acc_log_facility = LOG_DAEMON;
+static int cdr_log_level = L_NOTICE;
+static int cdr_log_facility = LOG_DAEMON;
+
 static int mod_init(void);
 static void destroy(void);
 static int child_init(int rank);
diff --git a/src/modules/acc_json/acc_json_mod.h b/src/modules/acc_json/acc_json_mod.h
index 25a3ac120e..62c3350faa 100644
--- a/src/modules/acc_json/acc_json_mod.h
+++ b/src/modules/acc_json/acc_json_mod.h
@@ -24,25 +24,6 @@
 #ifndef _ACC_JSON_MOD_H_
 #define _ACC_JSON_MOD_H_
 
-str acc_method_key = str_init("method");
-str acc_fromtag_key = str_init("from_tag");
-str acc_totag_key = str_init("to_tag");
-str acc_callid_key = str_init("callid");
-str acc_sipcode_key = str_init("sip_code");
-str acc_sipreason_key = str_init("sip_reason");
-str acc_time_key = str_init("time");
-
-str cdr_start_str = str_init("start_time");
-str cdr_end_str = str_init("end_time");
-str cdr_duration_str = str_init("duration");
-
 #define ACC_TIME_FORMAT_SIZE 128
-static char acc_time_format_buf[ACC_TIME_FORMAT_SIZE];
-char *acc_time_format = "%Y-%m-%d %H:%M:%S";
-
-int acc_log_level = L_NOTICE;
-int acc_log_facility = LOG_DAEMON;
-int cdr_log_level = L_NOTICE;
-int cdr_log_facility = LOG_DAEMON;
 
 #endif




More information about the sr-dev mailing list