[sr-dev] [kamailio/kamailio] presence_reginfo: Add option for aggregating reginfo presentities (PR #3240)

Matteo notifications at github.com
Thu Sep 22 09:32:58 CEST 2022


@xadhoom commented on this pull request.



> +
+				/* we do not copy the node, but unlink it and then add it ot the new node
+				 * this destroys the original document but we do not need it anyway.
+				 */
+				xmlUnlinkNode(node);
+				if(xmlAddChild(root_node, node) == NULL) {
+					xmlFreeNode(node);
+					LM_ERR("while adding child\n");
+					goto error;
+				}
+			} // end of loop over registration elements
+		}
+	} // end of loop over all bodies
+
+	// convert to string & cleanup
+	xml_array = (xmlDocPtr *)pkg_malloc(n * sizeof(xmlDocPtr));

This was indeed a typo, no reason to init the array again, sorry for that,

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3240#discussion_r977299122
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3240/review/1116525982 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220922/6e27132f/attachment.htm>


More information about the sr-dev mailing list