[sr-dev] [kamailio/kamailio] python3: `PyErr_SetString` is a void function. It doesn't return NULL. (PR #3231)

Matthias Urlichs notifications at github.com
Fri Sep 2 12:27:31 CEST 2022


#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description

`PyErr_SetString` is a void function. It doesn't return NULL.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3231

-- Commit Summary --

  * Python: must return NULL on error, not Py_None
  * modules/python3: return NULL on error.

-- File Changes --

    M src/modules/app_python3/python_msgobj.c (102)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3231.patch
https://github.com/kamailio/kamailio/pull/3231.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3231
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3231 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220902/c51c4857/attachment.htm>


More information about the sr-dev mailing list