[sr-dev] [kamailio/kamailio] pv: log uninit () (PR #3114)

Stefan Mititelu notifications at github.com
Tue May 17 12:13:07 CEST 2022


<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->
We've come into the rare issue when a kamailio process used the old $var() value for the current request message and messed some things up.

LOG_WARN when $var() is used uninitialized in config. I can also just LOG_NOTICE this.

Can this be brought to 5.6?

Thank you,
Stefan
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3114

-- Commit Summary --

  * pv: log uninit ()

-- File Changes --

    M src/modules/pv/pv_core.c (9)
    M src/modules/pv/pv_svar.h (1)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3114.patch
https://github.com/kamailio/kamailio/pull/3114.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3114
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3114 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220517/cb1306bf/attachment.htm>


More information about the sr-dev mailing list