[sr-dev] [kamailio/kamailio] module tm: kemi proto relay functions fails on TLS (PR #3110)

hallthmann notifications at github.com
Mon May 16 22:37:21 CEST 2022


<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->

module: tm
kemi proto relay functions fails on TLS
Functions: ki_t_relay_to_proto and ki_t_relay_to_proto_addr.
It's a simple fix, Just added a missing equal zero (== 0) on strncasecmp to TLS test to validate.

} else if (strncasecmp(sproto->s, "TLS", 3) == 0) {
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3110

-- Commit Summary --

  * Makefile.defs: version set to 5.7.0-dev0
  * pkg/kamailio/deb: version set 5.7.0~dev0 [skip ci]
  * db_berkeley: reset lkey to avoid double free
  * ipops: warning when too many dns containers are created
  * ipops: add dns container in dns_update_pv() if not created before
  * doc: Fix typos
  * pkg: Fix typos
  * core: Fix typos
  * lib: Fix typos
  * acc: Fix typos
  * auth: Fix typos
  * ctl: Fix typos
  * ldap: Fix typos
  * pike: Fix typos
  * sanity: Fix typos
  * tls: Fix typos
  * uid_auth_db: Fix typos
  * utils: Fix typos
  * modules: readme files regenerated - acc ... [skip ci]
  * userblocklist: fix restart errors
  * userblocklist: fix function comment, related to gh #3102
  * app_jsdt: duktape interpreter upgraded to v2.7.0
  * app_squirrel: updated squirrel interpreter to latest git version (3.2+)
  * usrloc: connect to db for main process in PROC_POSTCHILDINIT child init
  * dialog: open db connection in POSTCHILDINIT callback for DB_MODE_SHUTDOWN
  * mtree: remove single-used small function
  * geoip2: log errors for cases where the container could not evaluated and add docs
  * modules: readme files regenerated - geoip2 ... [skip ci]
  * core: xavp - helper function to shift xavps to left with rotation
  * pv: config function to shift xavps to left with rotation
  * pv: docs for xavp_lshift() function
  * modules: readme files regenerated - pv ... [skip ci]
  * pv: added $shvinc(name) - return incremented value of $shv(inc)
  * pv: use fixup get int value to evaluate the index parameter
  * pv: kemi function to get $shvinc(name) value
  * registrar: kemi functions to get $ulc(...) attributes
  * pv: declare pv wrapper function with two parameters
  * core: str - helerp macros to set str variable with char* value
  * registrar: added lookup_xavp("ultable", "uri", "rxname", "cxname")
  * registrar: docs for lookup_xavp(...)
  * registrar: proper attribute name for contact record xavp
  * modules: readme files regenerated - registrar ... [skip ci]
  * registrar: docs - removed extra closing tag
  * modules: readme files regenerated - registrar ... [skip ci]
  * core: socket info - function to get socket by listen or advertise
  * pv: xavp_push_dst(xname) function
  * pv: docs for xavp_push_dst()
  * pv: allow xavp_push_dst() in request/branch/failure_rotue
  * modules: readme files regenerated - pv ... [skip ci]
  * siptrace: fix hardcoded PROTO_UDP in duplicate_uri module parameter
  * core: add an option to trigger also an RST on tcp connection close
  * dialog: docs -remark wabout to-tag parameter for dlg_get()
  * modules: readme files regenerated - dialog ... [skip ci]
  * core: tcp main - check setsockopt() result for SO_LINGER
  * kazoo: docs - removed unnecessary xinclude entity
  * xlog: docs - updated section ids

-- File Changes --

    M doc/misc/NEWS (2)
    M doc/tutorials/locking.txt (4)
    M pkg/kamailio/deb/bionic/changelog (35)
    M pkg/kamailio/deb/bionic/rules (2)
    M pkg/kamailio/deb/bookworm/changelog (35)
    M pkg/kamailio/deb/bookworm/rules (2)
    M pkg/kamailio/deb/bullseye/changelog (35)
    M pkg/kamailio/deb/bullseye/rules (2)
    M pkg/kamailio/deb/buster/changelog (35)
    M pkg/kamailio/deb/buster/rules (2)
    M pkg/kamailio/deb/debian/changelog (35)
    M pkg/kamailio/deb/debian/rules (2)
    M pkg/kamailio/deb/focal/changelog (35)
    M pkg/kamailio/deb/focal/rules (2)
    M pkg/kamailio/deb/jessie/changelog (35)
    M pkg/kamailio/deb/jessie/rules (2)
    M pkg/kamailio/deb/precise/changelog (35)
    M pkg/kamailio/deb/precise/rules (2)
    M pkg/kamailio/deb/sid/changelog (35)
    M pkg/kamailio/deb/sid/rules (2)
    M pkg/kamailio/deb/stretch/changelog (35)
    M pkg/kamailio/deb/stretch/rules (2)
    M pkg/kamailio/deb/trusty/changelog (35)
    M pkg/kamailio/deb/trusty/rules (2)
    M pkg/kamailio/deb/wheezy/changelog (35)
    M pkg/kamailio/deb/wheezy/rules (2)
    M pkg/kamailio/deb/xenial/changelog (35)
    M pkg/kamailio/deb/xenial/rules (2)
    M src/Makefile.defs (4)
    M src/core/atomic/atomic_mips2.h (2)
    M src/core/cfg.lex (2)
    M src/core/cfg.y (9)
    M src/core/dns_cache.c (4)
    M src/core/forward.c (2)
    M src/core/resolve.c (4)
    M src/core/socket_info.c (13)
    M src/core/socket_info.h (1)
    M src/core/str.h (16)
    M src/core/tcp_main.c (23)
    M src/core/tcp_options.c (3)
    M src/core/tcp_options.h (1)
    M src/core/xavp.c (99)
    M src/core/xavp.h (1)
    M src/lib/cds/dstring.h (2)
    M src/lib/srdb1/schema/uid_credentials.xml (2)
    M src/lib/srdb2/db_cmd.c (4)
    M src/lib/srdb2/schema/credentials.xml (2)
    M src/modules/acc/README (2)
    M src/modules/acc/doc/acc_admin.xml (2)
    M src/modules/app_jsdt/duk_config.h (6)
    M src/modules/app_jsdt/duktape.c (21926)
    M src/modules/app_jsdt/duktape.h (22)
    M src/modules/app_sqlang/squirrel/include/squirrel.h (10)
    M src/modules/app_sqlang/squirrel/sqstdlib/sqstdblob.cpp (14)
    M src/modules/app_sqlang/squirrel/sqstdlib/sqstdio.cpp (4)
    M src/modules/app_sqlang/squirrel/sqstdlib/sqstdstream.cpp (2)
    M src/modules/app_sqlang/squirrel/sqstdlib/sqstdstring.cpp (42)
    M src/modules/app_sqlang/squirrel/squirrel/sqapi.cpp (30)
    M src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp (42)
    M src/modules/app_sqlang/squirrel/squirrel/sqclass.cpp (3)
    M src/modules/app_sqlang/squirrel/squirrel/sqclass.h (1)
    M src/modules/app_sqlang/squirrel/squirrel/sqcompiler.cpp (60)
    M src/modules/app_sqlang/squirrel/squirrel/sqstring.h (11)
    M src/modules/app_sqlang/squirrel/squirrel/sqtable.h (2)
    M src/modules/app_sqlang/squirrel/squirrel/sqvm.cpp (19)
    M src/modules/app_sqlang/squirrel/squirrel/sqvm.h (2)
    M src/modules/auth/challenge.c (2)
    M src/modules/auth/nonce.c (12)
    M src/modules/ctl/binrpc.h (4)
    M src/modules/db_berkeley/db_berkeley.c (4)
    M src/modules/dialog/README (3)
    M src/modules/dialog/dialog.c (10)
    M src/modules/dialog/doc/dialog_admin.xml (3)
    M src/modules/geoip2/README (2)
    M src/modules/geoip2/doc/geoip2_admin.xml (2)
    M src/modules/geoip2/geoip2_pv.c (4)
    M src/modules/ipops/ipops_pv.c (9)
    M src/modules/kazoo/doc/kazoo_admin.xml (3)
    M src/modules/ldap/README (2)
    M src/modules/ldap/doc/ldap_admin.xml (2)
    M src/modules/mtree/mtree_mod.c (21)
    M src/modules/pike/ip_tree.c (2)
    M src/modules/pv/README (169)
    M src/modules/pv/doc/pv_admin.xml (75)
    M src/modules/pv/pv.c (141)
    M src/modules/pv/pv_shv.c (62)
    M src/modules/pv/pv_shv.h (2)
    M src/modules/registrar/README (113)
    M src/modules/registrar/doc/registrar_admin.xml (77)
    M src/modules/registrar/registrar.c (47)
    M src/modules/registrar/regpv.c (239)
    M src/modules/registrar/regpv.h (7)
    M src/modules/sanity/sanity.c (2)
    M src/modules/sanity/sanity.h (2)
    M src/modules/siptrace/siptrace_send.c (2)
    M src/modules/tls/tls_server.c (2)
    M src/modules/uid_auth_db/authorize.c (2)
    M src/modules/userblocklist/db_userblocklist.c (3)
    M src/modules/usrloc/usrloc_mod.c (14)
    M src/modules/xlog/doc/xlog_admin.xml (4)
    M utils/kamctl/kamdbctl.pgsql (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3110.patch
https://github.com/kamailio/kamailio/pull/3110.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3110
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3110 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220516/18257db3/attachment-0001.htm>


More information about the sr-dev mailing list