[sr-dev] [kamailio/kamailio] IMS, P-CSCF: fix issues with UEs and ipsec tunnel (PR #3094)

[alexyosifov]

@alexyosifov requested changes on this pull request.

Just a small note:
Change: LM_ERR("Error using old IPSEC tunnel creation\n");
To: LM_DBG("Reusing old IPSEC tunnel creation\n");

> @@ -352,57 +351,26 @@ static int update_contact_ipsec_params(ipsec_t* s, const struct sip_msg* m, ipse
     s->ik.len = ik.len;
 
     // Generate SPI
-    if((s->spi_pc = acquire_spi()) == 0) {
-        LM_ERR("Error generating client SPI for IPSEC tunnel creation\n");
-        shm_free(s->ck.s);
-        s->ck.s = NULL; s->ck.len = 0;
-        shm_free(s->ik.s);
-        s->ik.s = NULL; s->ik.len = 0;
-        return -1;
+    if(s_old) {
+        if(s_old->spi_pc && s_old->spi_ps && s_old->port_pc && s_old->port_ps) {
+            LM_ERR("Error using old IPSEC tunnel creation\n");

Change log message to debug or info.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3094#pullrequestreview-960212148
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3094/review/960212148 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220513/5facc9b0/attachment.htm>