[sr-dev] [kamailio/kamailio] core: add an option to trigger also an RST on tcp connection close (PR #3100)

Rick Barenthin notifications at github.com
Mon May 2 17:04:03 CEST 2022


- This gives an option to also send RST in case kamailio closes the
  connection. There are cases where a FIN,ACK back forth leaves
  the connection in the host in TIME_WAIT state, but the ports on both
  sides are fixed. This leads to no request can send until
  the TIME_WAIT state is gone.

<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->
We have seen that in deployments where there are strict port requirements on both side, there are tcp connections in TIME_WAIT state causing no fresh TCP connections possible until the TIME_WAIT is gone. In a lot of these case the clients are sending from them self a RST after they send a FIN,ACK from there side but some aren't doing this. The basic idea of this PR is to give an extra option for the tcp configuration from the cfg to trigger always an RST on connection close from Kamailio side. This currently done by enabling SO_LINGER with a value of 0 just before close.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3100

-- Commit Summary --

  * core: add an option to trigger also an RST on tcp connection close

-- File Changes --

    M src/core/cfg.lex (2)
    M src/core/cfg.y (9)
    M src/core/tcp_main.c (7)
    M src/core/tcp_options.c (3)
    M src/core/tcp_options.h (1)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3100.patch
https://github.com/kamailio/kamailio/pull/3100.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3100
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3100 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220502/c1a784f7/attachment-0001.htm>


More information about the sr-dev mailing list