[sr-dev] [kamailio/kamailio] misleading-indentation warning (Issue #3012)

sergey-safarov notifications at github.com
Sat Jan 29 14:15:34 CET 2022


**1**
```
CC (gcc) [M sms.so]		libsms_putsms.o
CC (gcc) [M sms.so]		sms.o
CC (gcc) [M sms.so]		sms_funcs.o
sms_funcs.c: In function 'modem_process':
sms_funcs.c:884:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
  884 |                 if (used_mem)
      |                 ^~
sms_funcs.c:886:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  886 |                         for(i=1,k=1;k<=used_mem && i<=max_mem;i++) {
      |                         ^~~
CC (gcc) [M sms.so]		sms_report.o
LD (gcc) [M sms.so]		sms.so
CC (gcc) [M sst.so]		parse_sst.o
```
**2**
```
CC (gcc) [M ims_charging.so]		ims_charging_stats.o
CC (gcc) [M ims_charging.so]		ims_ro.o
ims_ro.c: In function 'create_cca_fui_avps':
ims_ro.c:1622:5: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
 1622 |     else
      |     ^~~~
ims_ro.c:1625:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
 1625 |         if (redirecturi && redirecturi->len >0 && redirecturi->s) {
      |         ^~
CC (gcc) [M ims_charging.so]		ro_avp.o
CC (gcc) [M ims_charging.so]		ro_db_handler.o
CC (gcc) [M ims_charging.so]		ro_fixup.o
```
**3**
```
CC (gcc) [M kazoo.so]		kazoo.o
CC (gcc) [M kazoo.so]		kz_amqp.o
kz_amqp.c: In function 'kz_amqp_channel_close':
kz_amqp.c:802:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
  802 |     if (!rmq)
      |     ^~
In file included from ../../core/mem/pkg.h:32,
                 from ../../core/mem/mem.h:41,
                 from kz_amqp.c:38:
../../core/mem/../dprint.h:298:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  298 |                         do { \
      |                         ^~
../../core/mem/../dprint.h:345:25: note: in expansion of macro 'LOG_FX'
  345 |                         LOG_FX(facility, level, lname, prefix, _FUNC_NAME_, fmt, ## args)
      |                         ^~~~~~
../../core/mem/../dprint.h:351:25: note: in expansion of macro 'LOG_FL'
  351 |                         LOG_FL(facility, level, NULL, prefix, fmt, ## args)
      |                         ^~~~~~
../../core/mem/../dprint.h:354:25: note: in expansion of macro 'LOG_FP'
  354 |                         LOG_FP(DEFAULT_FACILITY, (level), LOC_INFO, fmt, ## args)
      |                         ^~~~~~
../../core/mem/../dprint.h:401:45: note: in expansion of macro 'LOG'
  401 | #               define DBG(fmt, args...)    LOG(L_DBG, fmt , ## args)
      |                                             ^~~
../../core/mem/../dprint.h:405:36: note: in expansion of macro 'DBG'
  405 | #       define DEBUG(fmt, args...) DBG(fmt , ## args)
      |                                    ^~~
../../core/mem/../dprint.h:422:16: note: in expansion of macro 'DEBUG'
  422 | #define LM_DBG DEBUG
      |                ^~~~~
kz_amqp.c:805:9: note: in expansion of macro 'LM_DBG'
  805 |         LM_DBG("close channel: %d rmq(%p)->channel(%d)\n", getpid(), (void *)rmq, channel);
      |         ^~~~~~
kz_amqp.c: In function 'kz_amqp_pipe_send':
kz_amqp.c:1132:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
 1132 |     if(s_local_routing_key)
      |     ^~
kz_amqp.c:1135:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
 1135 |         return ret;
      |         ^~~~~~
kz_amqp.c: In function 'kz_amqp_subscribe_simple':
kz_amqp.c:2051:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
 2051 |     if(binding != NULL)
      |     ^~
kz_amqp.c:2054:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
 2054 |         return -1;
      |         ^~~~~~
CC (gcc) [M kazoo.so]		kz_fixup.o
CC (gcc) [M kazoo.so]		kz_hash.o
CC (gcc) [M kazoo.so]		kz_json.o
CC (gcc) [M kazoo.so]		kz_pua.o
CC (gcc) [M kazoo.so]		kz_trans.o
```
**4**
```
CC (gcc) [M ndb_redis.so]		ndb_redis_mod.o
CC (gcc) [M ndb_redis.so]		redis_client.o
redis_client.c: In function 'redisc_init':
redis_client.c:43:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                 ^~
redis_client.c:235:21: note: in expansion of macro 'redisCommandNR'
  235 |                 if (redisCommandNR(rsrv->ctxRedis, "PING")) {
      |                     ^~~~~~~~~~~~~~
redis_client.c:43:52: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                                                    ^~~~~
redis_client.c:235:21: note: in expansion of macro 'redisCommandNR'
  235 |                 if (redisCommandNR(rsrv->ctxRedis, "PING")) {
      |                     ^~~~~~~~~~~~~~
redis_client.c:43:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                 ^~
redis_client.c:240:51: note: in expansion of macro 'redisCommandNR'
  240 |                 if ((redis_cluster_param == 0) && redisCommandNR(rsrv->ctxRedis,
      |                                                   ^~~~~~~~~~~~~~
redis_client.c:43:52: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                                                    ^~~~~
redis_client.c:240:51: note: in expansion of macro 'redisCommandNR'
  240 |                 if ((redis_cluster_param == 0) && redisCommandNR(rsrv->ctxRedis,
      |                                                   ^~~~~~~~~~~~~~
redis_client.c: In function 'redisc_reconnect_server':
redis_client.c:43:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                 ^~
redis_client.c:549:13: note: in expansion of macro 'redisCommandNR'
  549 |         if (redisCommandNR(rsrv->ctxRedis, "PING"))
      |             ^~~~~~~~~~~~~~
redis_client.c:43:52: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                                                    ^~~~~
redis_client.c:549:13: note: in expansion of macro 'redisCommandNR'
  549 |         if (redisCommandNR(rsrv->ctxRedis, "PING"))
      |             ^~~~~~~~~~~~~~
redis_client.c:43:52: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                                                    ^~~~~
redis_client.c:549:13: note: in expansion of macro 'redisCommandNR'
  549 |         if (redisCommandNR(rsrv->ctxRedis, "PING"))
      |             ^~~~~~~~~~~~~~
redis_client.c:43:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                 ^~
redis_client.c:551:43: note: in expansion of macro 'redisCommandNR'
  551 |         if ((redis_cluster_param == 0) && redisCommandNR(rsrv->ctxRedis,
      |                                           ^~~~~~~~~~~~~~
redis_client.c:43:52: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                                                    ^~~~~
redis_client.c:551:43: note: in expansion of macro 'redisCommandNR'
  551 |         if ((redis_cluster_param == 0) && redisCommandNR(rsrv->ctxRedis,
      |                                           ^~~~~~~~~~~~~~
redis_client.c:43:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                 ^~
redis_client.c:555:21: note: in expansion of macro 'redisCommandNR'
  555 |                 if (redisCommandNR(rsrv->ctxRedis, "FLUSHALL"))
      |                     ^~~~~~~~~~~~~~
redis_client.c:43:52: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
   43 |                 if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;})
      |                                                    ^~~~~
redis_client.c:555:21: note: in expansion of macro 'redisCommandNR'
  555 |                 if (redisCommandNR(rsrv->ctxRedis, "FLUSHALL"))
      |                     ^~~~~~~~~~~~~~
LD (gcc) [M ndb_redis.so]		ndb_redis.so
CC (gcc) [M topos_redis.so]		topos_redis_mod.o
CC (gcc) [M topos_redis.so]		topos_redis_storage.o
```
**5**
```
CC (gcc) [M xhttp_pi.so]		xhttp_pi.o
CC (gcc) [M xhttp_pi.so]		xhttp_pi_fnc.o
xhttp_pi_fnc.c: In function 'ph_run_pi_cmd':
xhttp_pi_fnc.c:2904:25: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
 2904 |                         if(c_vals) pkg_free(c_vals); c_vals = NULL;
      |                         ^~
xhttp_pi_fnc.c:2904:54: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
 2904 |                         if(c_vals) pkg_free(c_vals); c_vals = NULL;
      |                                                      ^~~~~~
make[3]: 'libsrdb1.so.1.0' is up to date.
LD (gcc) [M xhttp_pi.so]		xhttp_pi.so
CC (gcc) [M xmlrpc.so]		http.o
CC (gcc) [M xmlrpc.so]		xmlrpc.o
LD (gcc) [M xmlrpc.so]		xmlrpc.so
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3012
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/issues/3012 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220129/d2a0f164/attachment.htm>


More information about the sr-dev mailing list