[sr-dev] [kamailio/kamailio] topos: disable multiple comma separated values in One Single Via, Record-Route or Route header if needed (PR #3220)

Daniel-Constantin Mierla notifications at github.com
Sat Aug 20 10:21:44 CEST 2022


The name of the parameter `separate_header_values` should be changed to `header_mode` to be even more generic and reused if anything else related to header management needs to be added in the future (e.g., add Via before or after Route).

>From implementation point of view, the current solution is "good enough" because it is doing a basic split on comma, working with the common format seen for these headers. Otherwise, at least the `Record/-Route` can have comma in its value, being defined as `name-addr` by grammar and in the eventuality of a display name, comma is allowed inside. Not sure if Via is allowed to have quoted value parameter, because I think inside it is also allowed to have comma.

Anyhow, given that this commit adds this behaviour for particular deployments when some UA doesn't support headers with multiple comma separated values, I am fine to merge the implementation as it is, after renaming the parameter.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3220#issuecomment-1221257132
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3220/c1221257132 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220820/5c2d59cd/attachment.htm>


More information about the sr-dev mailing list