[sr-dev] [kamailio/kamailio] pua_dialoginfo: Determine dialog event types in mod_init (PR #3079)

Henning Westerholt notifications at github.com
Tue Apr 12 07:49:35 CEST 2022


Thanks for the pull-request. I have not followed the complete code path yet, but I am not 100% sure this is the correct way to go.

In the existing code we are registering the DLGCB_REQ_WITHIN conditionally for the register_dlgcb(..) call. This will allocate new memory and copy the call back types to the new allocated structure. If you later change the callback types (as in your new code), it will be not synchronized with the structure inside the dialog module, or I am wrong?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3079#issuecomment-1096105868
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3079/c1096105868 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220411/ad23d591/attachment.htm>


More information about the sr-dev mailing list