[sr-dev] [kamailio/kamailio] lcr: improve binary search to support a match including src port (#2859)

[zenichev]

> After the binary match change, is it so that there is no need to change this test?
> 
> ```
> /* Store tag and flags and return result */
> 	if((res != NULL)
> 					&& ((transport == PROTO_NONE) || (res->transport_code == transport))
> 					&& ((src_port == 0) || (res->port == src_port))) {
> ```

Yes, you're right. Since the updated bsearch() already has ports comparison,
I think the following part looks excessive (doesn't break anything though):
`&& ((src_port == 0) || (res->port == src_port))) {`

I'll remove it.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2859#issuecomment-922425300
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210918/39e3f0b0/attachment.htm>