[sr-dev] [kamailio/kamailio] rtpengine: Don't recheck node if disabled permanently (PR #2886)

[Stefan Mititelu]

Hi @henningw,

The automatic re-enabling happens in certain conditions *and* after some time:
1. the conditions depend on:
1.1 `rtpengine_allow_op` to be set, so the manually disabled node can be returned (e.g. to allow his sessions to finish)
1.2 `send_rtpp_command()` function, when it returns NULL -> not sure exactly which one happened to us here. 
2. the time depends on `rtpengine_disable_tout` configured param.

So what happens is that on conditions 1. the `disabled (permanent)` (under maintenance) node becomes `disabled (temporary)`  with ```rn_recheck_ticks``` updated with time 2.  The (under maintenance) node is rechecked after that time and finds it still up and enables it (so new sessions can now be sent to it) -> though the desired behavior for the (under maintenance) node is just to let the existing one finish, not to accept new ones.

Hope this makes it a bit more clear.

Thank you,
Stefan

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2886#issuecomment-947632515
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20211020/47b2d217/attachment-0001.htm>