[sr-dev] [kamailio/kamailio] tls: update DH initialization for OpenSSL 1.1.x (PR #2945)

Daniel-Constantin Mierla notifications at github.com
Tue Nov 23 09:47:44 CET 2021


@miconda commented on this pull request.



> @@ -146,19 +156,17 @@ static void setup_dh(SSL_CTX *ctx)
 		return;
 	}
 
-#if (OPENSSL_VERSION_NUMBER >= 0x1010000fL) && !defined(LIBRESSL_VERSION_NUMBER)
-	/* libssl >= v1.1.0 */
-	DH_set0_pqg(dh, p, NULL, g);

In the PR description you mention `OpenSSL >= 1.1.1`, now the comments mention  `OpenSSL 1.1.0+`, so I am just asking for confirmation it is ok to remove the use of `DH_set0_pqg` here. If yes, then it will be merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2945#pullrequestreview-813357165
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20211123/ddbdb7b6/attachment.htm>


More information about the sr-dev mailing list