[sr-dev] [kamailio/kamailio] TSILO / TM. Lookup and branch creating by contact (location record). (PR #2931)

zenichev notifications at github.com
Sun Nov 14 22:26:11 CET 2021


@henningw @grumvalski what if we merge functions t_append_branches() and t_append_branch_by_contact() into one?
Hence leaving only the t_append_branches().

>From what I can see, it seems for now it's only TSILO who directly uses t_append_branches(). Correct me please if I'm wrong.

Proposed approach assumes, that the function signature will be changed, and a function parameter 'contact' of str type will be present. Then depending on if it's empty or not, act accordingly:
- If the contact parameter is given, then only a desired location  is meant for appending. If not found in the location table, an append will not happen for this AOR.
- Otherwise create branches for all existing location records of this particular AOR.

I have prepared the implementation and even tested that locally,
it seems to be functioning just fine when either calling TSILO's script function ts_append() and ts_append_by_contact().

Please let me know if you see it reasonable, then I will upload a new commit.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2931#issuecomment-968366470
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20211114/421bf847/attachment.htm>


More information about the sr-dev mailing list