[sr-dev] [kamailio/kamailio] kazoo: Allow optional AMQP-headers in kazoo_query and kazoo_publish (PR #2925)

mihovilkolaric notifications at github.com
Tue Nov 9 23:42:04 CET 2021


- implements GH #2895

<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #2895

#### Description
Allows adding additional AMQP-headers in the format header1=value1;header2=value2;...

Remark: 
I decided to re-use the definition 
`{"kazoo_publish", (cmd_function) kz_amqp_publish_ex, 4, fixup_kz_amqp, fixup_kz_amqp_free, ANY_ROUTE},`
resp. to modify the existing method signature
`int kz_amqp_publish_ex(struct sip_msg* msg, char* exchange, char* routing_key, char* payload, char* _pub_flags)`
to 
`int kz_amqp_publish_ex(struct sip_msg* msg, char* exchange, char* routing_key, char* payload, char* _pub_flags)`
as the param _pub_flags is neither described in the docs, nor it was evaluated/used, and thus was useless anyhow.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2925

-- Commit Summary --

  * <a href="https://github.com/kamailio/kamailio/pull/2925/commits/0aee8fc2c486f19a20c936a5098dab2d1d33f829">kazoo: Allow optional AMQP-headers in kazoo_query and kazoo_publish</a>

-- File Changes --

    M src/modules/kazoo/doc/kazoo_admin.xml (8)
    M src/modules/kazoo/kazoo.c (1)
    M src/modules/kazoo/kz_amqp.c (117)
    M src/modules/kazoo/kz_amqp.h (11)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2925.patch
https://github.com/kamailio/kamailio/pull/2925.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2925
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20211109/92bd3227/attachment.htm>


More information about the sr-dev mailing list