[sr-dev] [kamailio/kamailio] tm: t_suspend.c - t_continue_helper() - do not continue processing a reply if it's suspended again (#2721)

Daniel-Constantin Mierla notifications at github.com
Mon May 3 15:37:24 CEST 2021


The reset of faked env was something I wanted to ask about, but I didn't comment before because I didn't get the chance to look more at the code.

I think the t_suspend()/t_continue() were somehow limited to be used only once for a request or a reply, not to suspend again from a t_continue(). It does not mean that it has to stay like this, but your commit seems to affect re-suspending a reply. Have you looked also at re-suspending requests? It may just works, because request processing does not imply any forwarding of the message after config route execution, like happens for replies.

If the commit makes it coherent (i.e., re-suspending for requests and replies has similar behaviour), then the PR can be merged if no other comments.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2721#issuecomment-831264376
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210503/28f7afa2/attachment.htm>


More information about the sr-dev mailing list