[sr-dev] Kamailio mohqueu warning

[Robert Boisvert]

Daniel,

Yes, that is an error.  I should have used t_release_transaction()
instead.  I will correct it and resubmit.

My apologies.  I rebuilt the OS on this machine and I'm still trying to get
some things together.
Bob

On Wed, Mar 24, 2021 at 5:26 AM Daniel-Constantin Mierla <miconda at gmail.com>
wrote:

> Hello,
>
> compiling the latest version of Kamailio results in a warning for
> mohqueue module:
>
> CC (gcc) [M mohqueue.so]        mohq_funcs.o
> mohq_funcs.c:225:23: warning: incompatible pointer types passing
> 'tm_cell_t *' (aka 'struct cell *') to parameter of type 'struct sip_msg *'
>       [-Wincompatible-pointer-types]
>   if (ptm->t_release (ptcell) < 0)
>
> I noticed you pushed some changes recently, likely the warning was
> introduced by them, not noticing it before. Anyhow, it seems something
> that should be reviewed and fixed, otherwise may result in a crash by
> passing incorrect structure pointer.
>
> Cheers,
> Daniel
>
> --
> Daniel-Constantin Mierla -- www.asipto.com
> www.twitter.com/miconda -- www.linkedin.com/in/miconda
> Funding: https://www.paypal.me/dcmierla
>
>
> _______________________________________________
> Kamailio (SER) - Development Mailing List
> sr-dev at lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210324/ee208287/attachment-0001.htm>