[sr-dev] [kamailio/kamailio] extensions to lost and http_client modules (#2675)

Wolfgang Kampichler notifications at github.com
Tue Mar 16 11:18:18 CET 2021


> > Please don't create that much duplicated code. Make the old API function call the new as a wrapper with a null argument for content type header. That way we keep backwards compatibility and can add new functions.
> > Please also add new tests to the API test module.
> 
> Hi Olle, i think you are referring to the http_client part of this pull request? Which one in particular, not sure if you know that you can also add comments to individual functions in the review mode.

Hi Olle, Henning, I think I understood Olle's comment - I am about to implement the suggestion ...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2675#issuecomment-800132560
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210316/79a86681/attachment.htm>


More information about the sr-dev mailing list