[sr-dev] git:master:0010029f: Merge pull request #2667 from kamailio/revert-2666-master

[GitHub]

Module: kamailio
Branch: master
Commit: 0010029f95542b27ca197f071dd455aad04a9537
URL: https://github.com/kamailio/kamailio/commit/0010029f95542b27ca197f071dd455aad04a9537

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: GitHub <noreply at github.com>
Date: 2021-03-10T12:06:53+01:00

Merge pull request #2667 from kamailio/revert-2666-master

Revert "lrkproxy-fixed issue#2663"

---

Modified: src/modules/lrkproxy/lrkproxy.c

---

Diff:  https://github.com/kamailio/kamailio/commit/0010029f95542b27ca197f071dd455aad04a9537.diff
Patch: https://github.com/kamailio/kamailio/commit/0010029f95542b27ca197f071dd455aad04a9537.patch

---

diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c
index 1ef69bb9ac..2c0405c8a5 100644
--- a/src/modules/lrkproxy/lrkproxy.c
+++ b/src/modules/lrkproxy/lrkproxy.c
@@ -1224,21 +1224,18 @@ static int change_media_sdp(sip_msg_t *msg, struct lrkproxy_hash_entry *e, const
     start_sdp_c = strstr(off, "c=IN IP4");
     start_sdp_m = strstr(off, "m=audio");
 
-    //The external_ip should be set in config file for relaying RTP media between NIC.
-//    if (e->node->lrkp_n_c->external_ip && flags) {
-    if(flags) {
+    //if enabled then set direction,
+    if (e->node->lrkp_n_c->internal_ip && flags) {
         if (strstr(flags, "ei")) {
             ip_selected = e->node->lrkp_n_c->internal_ip;// lrk_node->internal_ip;
         } else if (strstr(flags, "ie")) {
             ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip;
         } else {
-            LM_INFO("unknown flags, use internal_ip\n");
-            ip_selected = e->node->lrkp_n_c->internal_ip;
+                    LM_INFO("no flags found\n");
+            return 0;
         }
-    }
-    else {
-        LM_INFO("no flags set, use internal_ip\n");
-        ip_selected = e->node->lrkp_n_c->internal_ip;
+    } else {
+        ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip;
     }
 
     if (op == OP_OFFER) {