[sr-dev] [kamailio/kamailio] lrkproxy: compile warning (#2663)

[Daniel-Constantin Mierla]

Yes, it is via de make command, but using clang not gcc (it is a compile on macos/bsd).

Practically at that line you check if the address of a char[20] buffer inside a structure is null:

```
struct lrkp_node_conf
{
    int start_port;
    int end_port;
    int current_port;
    char internal_ip[20];
    char external_ip[20];
};
```

It cannot be null, meaning that condition on `e->node->lrkp_n_c->internal_ip` is always true:

```
if (e->node->lrkp_n_c->internal_ip && flags) {
```

Maybe you wanted to test if its content is 0 (all chars internal_ip[i] with i=0..19 are 0). Or just remove `e->node->lrkp_n_c->internal_ip` from condition.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2663#issuecomment-793820507
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210309/b3912fa7/attachment.htm>