[sr-dev] [kamailio/kamailio] nats: new nats message consumer module (#2790)

[Sergey Safarov]

Maybe
q_

On Mon, Jun 28, 2021, 2:15 PM Henning Westerholt <hw at skalatan.de> wrote:

> Think the same, as we have already three modules implementing message
> queues:
>
>
>
> - mqtt
>
> - rabbitmq
>
> - kazoo
>
>
>
> I was thinking of “mq_” prefix, but this obviously do not fit well to the
> existing names.
>
>
>
> Cheers,
>
>
>
> Henning
>
> --
>
> Henning Westerholt – https://skalatan.de/blog/
>
> Kamailio services – https://gilawa.com
>
>
>
> *From:* sr-dev <sr-dev-bounces at lists.kamailio.org> *On Behalf Of *Olle E.
> Johansson
> *Sent:* Monday, June 28, 2021 1:10 PM
> *To:* Kamailio (SER) - Development Mailing List <sr-dev at lists.kamailio.org
> >
> *Subject:* Re: [sr-dev] [kamailio/kamailio] nats: new nats message
> consumer module (#2790)
>
>
>
> I find the name with potential to create confusion, being closed to NAT and
> we all know how popular that is and what it refers to in VoIP, but at the
> end I am fine with it given that it is the name of the external project.
> Maybe in the future if we end up with many distributed messaging platform
> modules, we can add a common prefix to all of them like we added for db
> module in the past.
>
> “msg_”
>
> “mbr_”
>
> “mbus_”
>
>
>
> Adding a prefix is a good thing.
>
>
>
> /O
>
>
>
> On 28 Jun 2021, at 09:42, Daniel-Constantin Mierla <
> notifications at github.com> wrote:
>
>
>
>
>
> Thanks for the new module!
>
> I find the name with potential to create confusion, being closed to NAT
> and we all know how popular that is and what it refers to in VoIP, but at
> the end I am fine with it given that it is the name of the external
> project. Maybe in the future if we end up with many distributed messaging
> platform modules, we can add a common prefix to all of them like we added
> for db module in the past.
>
> Regarding the code, I noticed that shm/pkg_malloc() results are not
> checked for NULL, which will result in crashes on low/out of memory cases.
> @eschmidbauer <https://github.com/eschmidbauer> has already git commit
> access, so I am fine to merge it and then push follow up commits for memory
> allocation checks.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/kamailio/kamailio/pull/2790#issuecomment-869451310>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABO7UZKHS7YN5JFPHCLSAQ3TVARUZANCNFSM47MJ3QRQ>
> .
>
> _______________________________________________
> Kamailio (SER) - Development Mailing List
> sr-dev at lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>
>
> _______________________________________________
> Kamailio (SER) - Development Mailing List
> sr-dev at lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210628/2f932a12/attachment-0001.htm>