[sr-dev] [kamailio/kamailio] tls: allow export session keys (#2785)

sergey-safarov notifications at github.com
Mon Jun 28 10:49:47 CEST 2021


I have checked openssl sources, loogs as `BIO_printf` and `BIO_write` function to not use lock mechanism.

> The solution would be to either have a lock around and do every time: lock, open file, write, close, unlock; 

Why we cannot open file once and use logic inside childs
```
lock, write, unlock
```

> I also noticed that the file name is reallocated in pkg using a local variable in a function and not freed.

is memory allocated here and not freed?
```diff
@@ -636,6 +710,7 @@ int tls_h_mod_pre_init_f(void)
 #endif
        SSL_load_error_strings();
        tls_mod_preinitialized=1;
+       prepare_keylog_file(cfg_get(tls, tls_cfg, session_keylog_filename));
        return 0;
 }

```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2785#issuecomment-869498796
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210628/d3a151bd/attachment.htm>


More information about the sr-dev mailing list