[sr-dev] [kamailio/kamailio] nathelper: don't fail if 'a=rtcp' has no IP (#2769)

Victor Seva notifications at github.com
Wed Jun 9 11:27:03 CEST 2021


Examples from RFC3605:
>    m=audio 49170 RTP/AVP 0
>    a=rtcp:53020
>
>    m=audio 49170 RTP/AVP 0
>    a=rtcp:53020 IN IP4 126.16.64.4
>
>    m=audio 49170 RTP/AVP 0
>    a=rtcp:53020 IN IP6 2001:2345:6789:ABCD:EF01:2345:6789:ABCD

fix #2768

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #2768 (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->

don't fail if there's no IP info if line is 'a=rtcp'
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2769

-- Commit Summary --

  * nathelper: don't fail if 'a=rtcp' has no IP

-- File Changes --

    M src/modules/nathelper/nathelper.c (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2769.patch
https://github.com/kamailio/kamailio/pull/2769.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2769
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210609/c7145369/attachment.htm>


More information about the sr-dev mailing list