[sr-dev] git:5.5:45310834: secsipid: log message on identity generation failure

[Daniel-Constantin Mierla]

Module: kamailio
Branch: 5.5
Commit: 45310834376d9eee2778e16c5fdc706ab1e6f97b
URL: https://github.com/kamailio/kamailio/commit/45310834376d9eee2778e16c5fdc706ab1e6f97b

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2021-06-01T10:59:04+02:00

secsipid: log message on identity generation failure

(cherry picked from commit 4b7eedf5af9a461d5a1de1148c814faa5db8cbaa)

---

Modified: src/modules/secsipid/secsipid_mod.c

---

Diff:  https://github.com/kamailio/kamailio/commit/45310834376d9eee2778e16c5fdc706ab1e6f97b.diff
Patch: https://github.com/kamailio/kamailio/commit/45310834376d9eee2778e16c5fdc706ab1e6f97b.patch

---

diff --git a/src/modules/secsipid/secsipid_mod.c b/src/modules/secsipid/secsipid_mod.c
index 30357a235e..18f962d362 100644
--- a/src/modules/secsipid/secsipid_mod.c
+++ b/src/modules/secsipid/secsipid_mod.c
@@ -327,6 +327,7 @@ static int ki_secsipid_add_identity(sip_msg_t *msg, str *origtn, str *desttn,
 			attest->s, origid->s, x5u->s, keypath->s, &ibody.s);
 
 	if(ibody.len<=0) {
+		LM_ERR("failed to get identity header body (%d)\n", ibody.len);
 		goto error;
 	}
 
@@ -526,9 +527,7 @@ static int secsipid_libopt_param(modparam_t type, void *val)
 		return -1;
 	}
 	sit->s = *((str*)val);
-	if(secsipid_libopt_list!=NULL) {
-		sit->next = secsipid_libopt_list;
-	}
+	sit->next = secsipid_libopt_list;
 	secsipid_libopt_list = sit;
 
 	return 0;