[sr-dev] git:5.5:f481071a: sipdump: fixed typo

Henning Westerholt hw at skalatan.de
Tue Jun 1 10:06:50 CEST 2021


Yes, but for such a small bug fix I do not wanted to do a manual commit just to fix the commit message.

-- 
Henning Westerholt – https://skalatan.de/blog/
Kamailio services – https://gilawa.com 

-----Original Message-----
From: sr-dev <sr-dev-bounces at lists.kamailio.org> On Behalf Of Olle E. Johansson
Sent: Tuesday, June 1, 2021 10:04 AM
To: Kamailio (SER) - Development Mailing List <sr-dev at lists.kamailio.org>
Subject: Re: [sr-dev] git:5.5:f481071a: sipdump: fixed typo



> On 1 Jun 2021, at 08:32, Henning Westerholt <hw at skalatan.de> wrote:
> 
> Module: kamailio
> Branch: 5.5
> Commit: f481071a671009f1dcc9fe5d36870e06edc2ec4b
> URL: 
> https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36
> 870e06edc2ec4b
> 
> Author: Sergey Safarov <s.safarov at gmail.com>
> Committer: Henning Westerholt <hw at skalatan.de>
> Date: 2021-06-01T06:32:25Z
> 
> sipdump: fixed typo
That’s not a typo, that is a change in the logic (to be picky). 

/O
> 
> (cherry picked from commit 7f226f5b08c93ed0a43113d7947730329ff7db38)
> 
> ---
> 
> Modified: src/modules/sipdump/sipdump_mod.c
> 
> ---
> 
> Diff:  
> https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36
> 870e06edc2ec4b.diff
> Patch: 
> https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36
> 870e06edc2ec4b.patch
> 
> ---
> 
> diff --git a/src/modules/sipdump/sipdump_mod.c 
> b/src/modules/sipdump/sipdump_mod.c
> index 54b5c47484..0384458639 100644
> --- a/src/modules/sipdump/sipdump_mod.c
> +++ b/src/modules/sipdump/sipdump_mod.c
> @@ -575,7 +575,7 @@ int pv_parse_sipdump_name(pv_spec_t *sp, str *in)
> 		case 8:
> 			if(strncmp(in->s, "src_port", 8)==0)
> 				sp->pvp.pvn.u.isname.name.n = 8;
> -			if(strncmp(in->s, "dst_port", 8)==0)
> +			else if(strncmp(in->s, "dst_port", 8)==0)
> 				sp->pvp.pvn.u.isname.name.n = 9;
> 			else goto error;
> 		break;
> 
> 
> _______________________________________________
> Kamailio (SER) - Development Mailing List sr-dev at lists.kamailio.org 
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev at lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


More information about the sr-dev mailing list