[sr-dev] git:5.5:d20841db: pv_headers: pvh_set_header, remove values to set null when necessary

Victor Seva linuxmaniac at torreviejawireless.org
Tue Jul 27 11:33:29 CEST 2021


Module: kamailio
Branch: 5.5
Commit: d20841db501fbc1a4053a6cb7293d3fa3f3fee94
URL: https://github.com/kamailio/kamailio/commit/d20841db501fbc1a4053a6cb7293d3fa3f3fee94

Author: Victor Seva <linuxmaniac at torreviejawireless.org>
Committer: Victor Seva <linuxmaniac at torreviejawireless.org>
Date: 2021-07-27T11:33:10+02:00

pv_headers: pvh_set_header, remove values to set null when necessary

* fix pvh_set_xavi for SR_XTYPE_NULL

(cherry picked from commit af926514ac3e70dff51408baf326b29bce4eecfc)

---

Modified: src/modules/pv_headers/pvh_xavp.c

---

Diff:  https://github.com/kamailio/kamailio/commit/d20841db501fbc1a4053a6cb7293d3fa3f3fee94.diff
Patch: https://github.com/kamailio/kamailio/commit/d20841db501fbc1a4053a6cb7293d3fa3f3fee94.patch

---

diff --git a/src/modules/pv_headers/pvh_xavp.c b/src/modules/pv_headers/pvh_xavp.c
index 96fdc292b0..b8e4f92e61 100644
--- a/src/modules/pv_headers/pvh_xavp.c
+++ b/src/modules/pv_headers/pvh_xavp.c
@@ -375,7 +375,7 @@ int pvh_set_xavi(struct sip_msg *msg, str *xname, str *name, void *data,
 	LM_DBG("br_xname: %.*s name: %.*s append:%d\n", br_xname.len, br_xname.s,
 			name->len, name->s, append);
 	memset(&xval, 0, sizeof(sr_xval_t));
-	if(data == NULL || SR_XTYPE_NULL) {
+	if(data == NULL || type == SR_XTYPE_NULL) {
 		xval.type = SR_XTYPE_NULL;
 	} else if(type == SR_XTYPE_STR) {
 		xval.type = SR_XTYPE_STR;
@@ -618,9 +618,11 @@ int pvh_set_header(
 
 	if(val == NULL || (val->flags & PV_VAL_NULL)) {
 		if(idxf == PV_IDX_ALL) {
-			cnt = xavi_rm_by_name(hname, 1, &avi);
-			LM_DBG("removed %d values of %.*s=>%.*s, set $null\n", cnt,
-					xavi->name.len, xavi->name.s, hname->len, hname->s);
+			if(hname_cnt > 1) {
+				cnt = xavi_rm_by_name(hname, 1, &avi);
+				LM_DBG("removed %d values of %.*s=>%.*s, set $null\n", cnt,
+						xavi->name.len, xavi->name.s, hname->len, hname->s);
+			}
 			if(pvh_set_xavi(msg, &xavi_name, hname, NULL, SR_XTYPE_NULL, 0, 0)
 					< 0)
 				goto err;




More information about the sr-dev mailing list