[sr-dev] [kamailio/kamailio] rtpengine: rtpengine_allow_op return node logic (#2800)

[Henning Westerholt]

Looks good to me. From the documentation this feature should work like this in the first place.

But I did a review of the code, and it seems this feature was modified to actually work in the (in your opinion not desired way), but probably the docs not adapted. See below.

So probably a better idea is to introduce another mode "2" for the rtpengine_allow_op parameter which then trigger the desired behaviour.

> commit 5a537506141027ca3d3ef87f49913ab628c30690
> Author: Stefan Mititelu <stefan.mititelu at 1and1.ro>
> Date:   Mon Dec 7 13:30:02 2015 +0200
> 
>     rtpengine: Allow op for all deactivated machines
> 
>     If allow_op modparam enabled, send commands to the disabled machines for the
>     existing call. So far this was done only for manually deactivated machines.
>     This is useful because there might be cases of proxy timeout, cases when you
>     may want to still allow the operations for the existing calls.
> 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2800#issuecomment-878264302
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210712/e8262e2d/attachment.htm>