[sr-dev] [kamailio/kamailio] lost: new features LoST redirect and NAPTR lookup (#2606)

Daniel-Constantin Mierla notifications at github.com
Wed Jan 27 17:20:55 CET 2021


@wkampich - one clarification, maybe my first comment was confusing: there can be pull requests that change code in many modules, but it has to contain commits per module/component. In the first version of the PR, there was a part of the commit that changed http_client module along with the lost module.

I wanted to say that the PR has to contain two commits, one for http_client module and the other for the lost module. A PR is not restricted to a single commit. With the latest commit in this PR, I see that the part for http_client is no longer present.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2606#issuecomment-768400392
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210127/ad7ece52/attachment-0001.htm>


More information about the sr-dev mailing list