[sr-dev] [kamailio/kamailio] dispatcher: Log dest sets after variable update (#2608)

Marat notifications at github.com
Mon Jan 25 16:36:56 CET 2021


<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->

I found that zero servers are being logged, even though they are (ignore the line numbers, the file is slightly modified):
```
 0(15681) DEBUG: dispatcher [dispatch.c:919]: ds_load_list(): found [0] dest sets
 0(15681) DEBUG: dispatcher [dispatch.c:222]: ds_log_dst_cb(): dst>> 1031 sip:127.0.0.1:5182 0 0 (,0,0,0)
 0(15681) DEBUG: dispatcher [dispatch.c:222]: ds_log_dst_cb(): dst>> 1011 sip:127.0.0.1:5180 0 0 (,0,0,0)
 0(15681) DEBUG: dispatcher [dispatch.c:222]: ds_log_dst_cb(): dst>> 1021 sip:127.0.0.1:5181 0 0 (,0,0,0)
```
Therefore, I moved the logging of the dest sets after updating variable and this fixed the error.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2608

-- Commit Summary --

  * dispatcher: Log dest sets after variable update

-- File Changes --

    M src/modules/dispatcher/dispatch.c (8)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2608.patch
https://github.com/kamailio/kamailio/pull/2608.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2608
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210125/5653b152/attachment.htm>


More information about the sr-dev mailing list