[sr-dev] [kamailio/kamailio] core: Add virtual flag to listen config to ignore inactive ip addresses (PR #2985)

rhys-hanrahan notifications at github.com
Wed Dec 22 12:22:51 CET 2021


<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [X] Related to issue #2984

#### Description

A new option to "listen" has been added called "virtual". This sets a flag on the listening socket to modify the behaviour of grep_sock_info. When this flag is set, grep_sock_info will only consider the listening IP a match if the IP is found in the system's current list of local IP addresses. If the IP is not currently local, then the matching IP is ignored.

If the virtual flag is not set on the socket then existing behaviour used instead.

This feature is intended for scenarios where you have two Kamailio nodes in active/active setup, with virtual IPs, where you need to be able to listen on a virtual IP but it may not always be active locally. With this flag applied to a `listen=` socket, Kamailio will only consider traffic destined to this IP local, when the IP is actually active on the system, and other times the match is ignored.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2985

-- Commit Summary --

  * core: listen can now have a "virtual" flag to check for nonlocal floating IPs.
  * etc: kamailio.cfg - added example use of listen's new virtual flag.
  * core: Added virtual flag to output of core.sockets_list
  * corex: Added virtual flag to output of "corex.list_sockets"
  * ims_ipsec_pcscf: Added virtual flag to output of sockets list.

-- File Changes --

    M etc/kamailio.cfg (2)
    M src/core/cfg.lex (2)
    M src/core/cfg.y (83)
    M src/core/core_cmd.c (10)
    M src/core/ip_addr.h (1)
    M src/core/socket_info.c (85)
    M src/modules/corex/corex_rpc.c (5)
    M src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c (8)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2985.patch
https://github.com/kamailio/kamailio/pull/2985.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2985
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/2985 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20211222/b9cb15db/attachment.htm>


More information about the sr-dev mailing list