[sr-dev] [kamailio/kamailio] core: logging: JSON: add CEE schema support (#2826)

Henning Westerholt notifications at github.com
Mon Aug 16 22:42:11 CEST 2021


Thanks for the pull request. Just a few notes, other might be able to comment more:
- instead of extending the core and adding another command line parameter for it, I think it should be implemented as a extension module, similar e.g. to log_systemd module
- the code includes pthread.h and also calls pthread_self(), this should be not necessary as there is no pthread_create() in the core right now (Kamailio uses mainly the multi-process model)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2826#issuecomment-899804837
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210816/aefa125e/attachment.htm>


More information about the sr-dev mailing list