[sr-dev] git:master:1d6736d1: topos: restore checks on uri and sip_params for tps_dlg_message_update()

[Daniel-Constantin Mierla]

Module: kamailio
Branch: master
Commit: 1d6736d16ab3a83b77d6c7be3f9689c7fbfccf28
URL: https://github.com/kamailio/kamailio/commit/1d6736d16ab3a83b77d6c7be3f9689c7fbfccf28

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2021-04-26T13:49:42+02:00

topos: restore checks on uri and sip_params for tps_dlg_message_update()

- use define for expected min len safety checks

---

Modified: src/modules/topos/tps_msg.c

---

Diff:  https://github.com/kamailio/kamailio/commit/1d6736d16ab3a83b77d6c7be3f9689c7fbfccf28.diff
Patch: https://github.com/kamailio/kamailio/commit/1d6736d16ab3a83b77d6c7be3f9689c7fbfccf28.patch

---

diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c
index cbf8b3c9f3..852a19aaa2 100644
--- a/src/modules/topos/tps_msg.c
+++ b/src/modules/topos/tps_msg.c
@@ -309,17 +309,18 @@ int tps_dlg_message_update(sip_msg_t *msg, tps_data_t *ptsd, int ctmode)
 	str tuuid = STR_NULL;
 	int ret;
 
+#define TPS_TUUID_MIN_LEN 10
+
 	if(parse_sip_msg_uri(msg)<0) {
 		LM_ERR("failed to parse r-uri\n");
 		return -1;
 	}
 
-	if(msg->parsed_uri.sip_params.len<10) {
-		LM_DBG("not an expected %s format\n", (ctmode==0)?"user":"param");
-		return 1;
-	}
-
 	if (ctmode == 1 || ctmode == 2) {
+		if(msg->parsed_uri.sip_params.len<TPS_TUUID_MIN_LEN) {
+			LM_DBG("not an expected param format\n");
+			return 1;
+		}
 		/* find the r-uri parameter */
 		ret = tps_get_param_value(&msg->parsed_uri.params,
 			&_tps_cparam_name, &tuuid);
@@ -332,6 +333,10 @@ int tps_dlg_message_update(sip_msg_t *msg, tps_data_t *ptsd, int ctmode)
 			return 1;
 		}
 	} else {
+		if(msg->parsed_uri.user.len<TPS_TUUID_MIN_LEN) {
+			LM_DBG("not an expected user format\n");
+			return 1;
+		}
 		tuuid = msg->parsed_uri.user;
 	}