[sr-dev] [kamailio/kamailio] registrar: added new parameter sock_addr (#2498)

Daniel-Constantin Mierla notifications at github.com
Thu Oct 8 07:32:49 CEST 2020


Looking at the combined diff against existing code, I think the condition on sock_flag has to be processed first (higher priority), respectively:

```
if (_m->flags&sock_flag) {
```

Because that is a config admin instructing to take the value from a different place. With this PR, that will never work when advertised address is set.

Moreover, using advertised address (the `useinfo`) should be controlled via a modparam, because from sip routing point of view it is more useful to have local listen socket than the public ip. So it needs a new parameter for having this new feature enabled.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2498#issuecomment-705340039
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20201007/ba7c266b/attachment-0001.htm>


More information about the sr-dev mailing list