[sr-dev] [kamailio/kamailio] nathelper: fix_nated_sdp added support for a=rtcp param RFC3605 (#2497)

[Arsen Semenov]

Hi Olle,

internally function acts the same way as before, so for the above cases it yields the following results:

If there is no IP address in the rtcp attribute - nothing will be changed.

If param has an IPv4  - it will be replaced with the msg source IP address - if only the first argument (flags 0x02, 0x08, 0x10) is passed. Or with the IP address passed as the second argument. 

If param contains IPv6 - nothing will be changed. 

a possible issue, I have found in my tests, is that it is possible to pass IPv6 as a second argument to the function and it will replace IPv4 address leading to address family mismatch. (e.g c=IN IP4 2001:2345:6789:ABCD:EF01:2345:6789:ABCD) 
Probably should be mentioned in the nathelper admin guide. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2497#issuecomment-703568293
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20201005/580a0079/attachment.htm>