[sr-dev] [kamailio/kamailio] smsops: fix len calc for a concatenated sms (#2556)

[Daniel-Constantin Mierla]

@miconda commented on this pull request.



> @@ -618,6 +627,7 @@ int decode_3gpp_sms(struct sip_msg *msg) {
 					// Coding: 7 Bit
 					if (rp_data->pdu.coding == 0x00) {
 						// We don't care about the extra used bytes here.
+						rp_data->pdu.payload.sm.len = len;
 						rp_data->pdu.payload.sm.len = gsm_to_ascii(&body.s[p], len, rp_data->pdu.payload.sm, fill_bits);

Above are now two assignments one after the other to `rp_data->pdu.payload.sm.len`, is it `rp_data->pdu.payload.sm.len` used inside `gsm_to_ascii()`? Asking because len is also provided as parameter to `gsm_to_ascii()`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2556#pullrequestreview-537417782
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20201124/64d9cbb0/attachment.htm>