[sr-dev] pv module problems on master

[Daniel-Constantin Mierla]

They were from the previous commits indeed -- clang on mac was not
reporting them. I just pushed patches to fix them.

Cheers,
Daniel

On 06.03.20 23:22, Juha Heinanen wrote:
> May have something to do with recent two commits.
>
> -- Juha
>
> -----------------------------------------------------------------------
>
> CC (gcc) [M pv.so]		pv_trans.o
> pv_trans.c: In function 'tr_eval_string':
> pv_trans.c:539:22: warning: pointer targets in passing argument 1 of 'base64url_enc' differ in signedness [-Wpointer-sign]
>     i = base64url_enc((unsigned char *) val->rs.s, val->rs.len,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:867:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_enc(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
> pv_trans.c:540:6: warning: pointer targets in passing argument 3 of 'base64url_enc' differ in signedness [-Wpointer-sign]
>       (unsigned char *) _tr_buffer, TR_BUFFER_SIZE-1);
>       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:867:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_enc(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
> pv_trans.c:552:22: warning: pointer targets in passing argument 1 of 'base64url_dec' differ in signedness [-Wpointer-sign]
>     i = base64url_dec((unsigned char *) val->rs.s, val->rs.len,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:868:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_dec(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
> pv_trans.c:553:6: warning: pointer targets in passing argument 3 of 'base64url_dec' differ in signedness [-Wpointer-sign]
>       (unsigned char *) _tr_buffer, TR_BUFFER_SIZE-1);
>       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:868:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_dec(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
> pv_trans.c:565:22: warning: pointer targets in passing argument 1 of 'base64url_enc' differ in signedness [-Wpointer-sign]
>     i = base64url_enc((unsigned char *) val->rs.s, val->rs.len,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:867:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_enc(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
> pv_trans.c:566:6: warning: pointer targets in passing argument 3 of 'base64url_enc' differ in signedness [-Wpointer-sign]
>       (unsigned char *) _tr_buffer, TR_BUFFER_SIZE-1);
>       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:867:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_enc(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
> pv_trans.c:597:23: warning: pointer targets in passing argument 1 of 'base64url_dec' differ in signedness [-Wpointer-sign]
>      i = base64url_dec((unsigned char *) st.s, st.len,
>                        ^~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:868:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_dec(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
> pv_trans.c:598:7: warning: pointer targets in passing argument 3 of 'base64url_dec' differ in signedness [-Wpointer-sign]
>        (unsigned char *) _tr_buffer, TR_BUFFER_SIZE-1);
>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:868:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_dec(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
> pv_trans.c:600:23: warning: pointer targets in passing argument 1 of 'base64url_dec' differ in signedness [-Wpointer-sign]
>      i = base64url_dec((unsigned char *) val->rs.s, val->rs.len,
>                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:868:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_dec(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
> pv_trans.c:601:7: warning: pointer targets in passing argument 3 of 'base64url_dec' differ in signedness [-Wpointer-sign]
>        (unsigned char *) _tr_buffer, TR_BUFFER_SIZE-1);
>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from pv_trans.c:40:
> ../../core/basex.h:868:5: note: expected 'char *' but argument is of type 'unsigned char *'
>  int base64url_dec(char *in, int ilen, char *out, int osize);
>      ^~~~~~~~~~~~~
>
> ------------------------------------------------------------------------
>
> Mar  7 00:15:46 char sip-proxy[21381]:  0(21433) ERROR: <core> [core/sr_module.c:512]: load_module(): could not open module </usr/lib/x86_64-linux-gnu/sip-proxy/modules/pv.so>: /usr/lib/x86_64-linux-gnu/sip-proxy/modules/pv.so: undefined symbol: base64url_enc
>
> _______________________________________________
> Kamailio (SER) - Development Mailing List
> sr-dev at lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - March 9-11, 2020, Berlin - www.asipto.com
Kamailio World Conference - April 27-29, 2020, in Berlin -- www.kamailioworld.com