[sr-dev] git:master:df5521fc: ims_qos: use extern in header files not to redeclare variables

Daniel-Constantin Mierla miconda at gmail.com
Wed Mar 4 08:29:20 CET 2020


Module: kamailio
Branch: master
Commit: df5521fcdfc96462eb191b774f242fe1d4616adb
URL: https://github.com/kamailio/kamailio/commit/df5521fcdfc96462eb191b774f242fe1d4616adb

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2020-03-04T08:28:30+01:00

ims_qos: use extern in header files not to redeclare variables

---

Modified: src/modules/ims_qos/cdpeventprocessor.h
Modified: src/modules/ims_qos/rx_aar.c
Modified: src/modules/ims_qos/rx_aar.h
Modified: src/modules/ims_qos/rx_avp.h

---

Diff:  https://github.com/kamailio/kamailio/commit/df5521fcdfc96462eb191b774f242fe1d4616adb.diff
Patch: https://github.com/kamailio/kamailio/commit/df5521fcdfc96462eb191b774f242fe1d4616adb.patch

---

diff --git a/src/modules/ims_qos/cdpeventprocessor.h b/src/modules/ims_qos/cdpeventprocessor.h
index 4f2b4d688f..8f393656ee 100644
--- a/src/modules/ims_qos/cdpeventprocessor.h
+++ b/src/modules/ims_qos/cdpeventprocessor.h
@@ -67,8 +67,8 @@ typedef struct {
 	int size;
 } cdp_cb_event_list_t;
 
-str early_qosrelease_reason;
-str confirmed_qosrelease_headers;
+extern str early_qosrelease_reason;
+extern str confirmed_qosrelease_headers;
 
 int init_cdp_cb_event_list();
 void destroy_cdp_cb_event_list();
diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c
index 684f3a75c5..2029035415 100644
--- a/src/modules/ims_qos/rx_aar.c
+++ b/src/modules/ims_qos/rx_aar.c
@@ -71,7 +71,7 @@
 #define macro_name(_rc)	#_rc
 
 //extern struct tm_binds tmb;
-usrloc_api_t ul;
+extern usrloc_api_t ul;
 
 extern struct ims_qos_counters_h ims_qos_cnts_h;
 
diff --git a/src/modules/ims_qos/rx_aar.h b/src/modules/ims_qos/rx_aar.h
index f12def162f..0a9a63b51a 100644
--- a/src/modules/ims_qos/rx_aar.h
+++ b/src/modules/ims_qos/rx_aar.h
@@ -55,7 +55,7 @@
 #include "../../core/locking.h"
 
 struct cdp_binds cdpb;
-cdp_avp_bind_t *cdp_avp;
+extern cdp_avp_bind_t *cdp_avp;
 
 /*this is the parcel to pass for CDP async for AAR*/
 typedef struct saved_transaction {
diff --git a/src/modules/ims_qos/rx_avp.h b/src/modules/ims_qos/rx_avp.h
index c8f81b6f85..55840f3e81 100644
--- a/src/modules/ims_qos/rx_avp.h
+++ b/src/modules/ims_qos/rx_avp.h
@@ -64,8 +64,8 @@ struct AAA_AVP_List;
 struct AAAMessage;
 enum dialog_direction;
 
-int audio_default_bandwidth;
-int video_default_bandwidth;
+extern int audio_default_bandwidth;
+extern int video_default_bandwidth;
 
 
 /*helper*/




More information about the sr-dev mailing list