[sr-dev] [kamailio/kamailio] core: Improve handling of async-signal-unsafe code in signal handler (#2127)

Daniel-Constantin Mierla notifications at github.com
Mon Jun 15 21:13:08 CEST 2020


@linuxmaniac - thanks for the reminder. I also looked at this PR a while ago, but forgot to comment.

The version of kamailio is not provided to match the source code line from backtrace, but it seems to be related to printing the memory usage logs at shutdown.

Based on my understanding so far, I do not see the usefulness of this PR at all. The memory status report/summary is printed only if some global parameters are set, respectively `memlog` less or equal than `debug` and `mem_summary` different than `0`.

in my opinion, there are enough options to disable printing the memory logs at the shutdown, if one faces problems with them. Actually they are not printed using the default config, one needs to change those params to get them printed.

Anyhow, if I misunderstood, definitely I do not want a compile flag (macro) to disable/enable shutdown reports, it has to be a global param. It is not convenient to recompile the sources if it is need of more info for troubleshooting.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2127#issuecomment-644325130
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20200615/509c430a/attachment-0001.html>


More information about the sr-dev mailing list