[sr-dev] git:5.3:ccf7347e: cdp: add missing line-breaks for log messages

Henning Westerholt hw at skalatan.de
Wed Jun 10 13:52:21 CEST 2020


Module: kamailio
Branch: 5.3
Commit: ccf7347e9f756b36e5baa65d93dab520098d3993
URL: https://github.com/kamailio/kamailio/commit/ccf7347e9f756b36e5baa65d93dab520098d3993

Author: Henning Westerholt <hw at skalatan.de>
Committer: Henning Westerholt <hw at skalatan.de>
Date: 2020-06-10T11:52:04Z

cdp: add missing line-breaks for log messages

(cherry picked from commit 32a0d8073eb1b7f01190d305d318b43268811be8)

---

Modified: src/modules/cdp/acctstatemachine.c
Modified: src/modules/cdp/peerstatemachine.c
Modified: src/modules/cdp/receiver.c
Modified: src/modules/cdp/worker.c

---

Diff:  https://github.com/kamailio/kamailio/commit/ccf7347e9f756b36e5baa65d93dab520098d3993.diff
Patch: https://github.com/kamailio/kamailio/commit/ccf7347e9f756b36e5baa65d93dab520098d3993.patch

---

diff --git a/src/modules/cdp/acctstatemachine.c b/src/modules/cdp/acctstatemachine.c
index 4e9272980f..a0c5f26ad8 100644
--- a/src/modules/cdp/acctstatemachine.c
+++ b/src/modules/cdp/acctstatemachine.c
@@ -40,7 +40,7 @@ void update_gsu_response_timers(cdp_cc_acc_session_t* session, AAAMessage* msg)
 	AAA_AVP *mscc_avp = mscc_avp_list.head;
 
 	while (mscc_avp != NULL ) {
-		LM_DBG("MSCC AVP code is [%i] and data length is [%i]", mscc_avp->code, mscc_avp->data.len);
+		LM_DBG("MSCC AVP code is [%i] and data length is [%i]\n", mscc_avp->code, mscc_avp->data.len);
 		switch (mscc_avp->code) {
 			case AVP_Granted_Service_Unit:
 				y = AAAUngroupAVPS(mscc_avp->data);
diff --git a/src/modules/cdp/peerstatemachine.c b/src/modules/cdp/peerstatemachine.c
index 5d26605c70..ed49a3ad30 100644
--- a/src/modules/cdp/peerstatemachine.c
+++ b/src/modules/cdp/peerstatemachine.c
@@ -695,7 +695,7 @@ int count_Supported_Vendor_Id_AVPS(AAAMessage *msg)
 			break;
 		avp_vendor = AAAFindMatchingAVP(msg,avp_vendor->next,AVP_Supported_Vendor_Id,0,0);
 	}
-	LM_DBG("Found %i Supported_Vendor AVPS", avp_vendor_cnt);
+	LM_DBG("Found %i Supported_Vendor AVPS\n", avp_vendor_cnt);
 	return avp_vendor_cnt;
 }
 
diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c
index c33554457a..5aed0a36f4 100644
--- a/src/modules/cdp/receiver.c
+++ b/src/modules/cdp/receiver.c
@@ -396,7 +396,7 @@ static int receive_fd(int pipe_fd, int* fd,peer **p)
 		*fd = *tmp;
 	}else{
 		if(!cmsg)
-			LM_ERR("receive_fd: no descriptor passed, empty control message");
+			LM_ERR("receive_fd: no descriptor passed, empty control message\n");
 		else
 			LM_ERR("receive_fd: no descriptor passed, cmsg=%p,"
 					"len=%d\n", cmsg, (unsigned)cmsg->cmsg_len);
@@ -768,7 +768,7 @@ int receive_loop(peer *original_peer)
 							}
 							LM_DBG("select_recv(): Send pipe says [%p] %d\n",msg,cnt);
 							if (sp->tcp_socket<0){
-								LM_ERR("select_recv(): got a signal to send something, but the connection was not opened");
+								LM_ERR("select_recv(): got a signal to send something, but the connection was not opened\n");
 							} else {
 								while( (cnt=write(sp->tcp_socket,msg->buf.s,msg->buf.len))==-1 ) {
 									if (errno==EINTR)
@@ -883,7 +883,7 @@ int peer_connect(peer *p)
 
 		/* try to set the local socket used to connect to the peer */
 		if (p->src_addr.s && p->src_addr.len > 0) {
-			LM_DBG("peer_connect(): connetting to peer via src addr=%.*s",p->src_addr.len, p->src_addr.s);
+			LM_DBG("peer_connect(): connecting to peer via src addr=%.*s\n",p->src_addr.len, p->src_addr.s);
 			memset (&hints, 0, sizeof(hints));
 			hints.ai_flags = AI_NUMERICHOST;
 			hints.ai_socktype = SOCK_STREAM;
diff --git a/src/modules/cdp/worker.c b/src/modules/cdp/worker.c
index 30d7a1b0fe..64ba70679f 100644
--- a/src/modules/cdp/worker.c
+++ b/src/modules/cdp/worker.c
@@ -258,11 +258,11 @@ int put_task(peer *p, AAAMessage *msg) {
 		length_percentage = num_tasks/tasks->max*100;
 		if(length_percentage > workerq_length_threshold_percentage) {
 			LM_WARN("Queue length has exceeded length threshold percentage"
-					" [%i] and is length [%i]", length_percentage, num_tasks);
+					" [%i] and is length [%i]\n", length_percentage, num_tasks);
 		}
 	}
 	//int num_tasks = tasks->end - tasks->start;
-	//LM_ERR("Added task to task queue.  Queue length [%i]", num_tasks);
+	//LM_ERR("Added task to task queue.  Queue length [%i]\n", num_tasks);
 
 
 	return 1;
@@ -300,7 +300,7 @@ task_t take_task() {
 	lock_release(tasks->lock);
 
 	//int num_tasks = tasks->end - tasks->start;
-	//LM_ERR("Taken task from task queue.  Queue length [%i]", num_tasks);
+	//LM_ERR("Taken task from task queue.  Queue length [%i]\n", num_tasks);
 
 
 	return t;




More information about the sr-dev mailing list