[sr-dev] [kamailio/kamailio] core: don't close tcp connection for dropped non sip messages (#2396)

lazedo notifications at github.com
Mon Jul 13 14:07:34 CEST 2020


#### Pre-Submission Checklist
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [X] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
when handling non sip messages in a module thru the callback, if we return `NONSIP_MSG_DROP` the tcp/websocket connection is closed. this was observed when receiving non sip messages with websocket module.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2396

-- Commit Summary --

  * core: don't close tcp connection for dropped non sip messages

-- File Changes --

    M src/core/receive.c (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2396.patch
https://github.com/kamailio/kamailio/pull/2396.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2396
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20200713/2d7067bf/attachment.htm>


More information about the sr-dev mailing list