[sr-dev] [kamailio/kamailio] userblacklist: added missing kemi functions (#2190)

Daniel-Constantin Mierla notifications at github.com
Mon Jan 6 18:35:05 CET 2020


miconda commented on this pull request.



> +		LM_ERR("no table name\n");
+		return -1;
+	}
+	/* try to add the table */
+	if (add_source(table) != 0) {
+		LM_ERR("could not add table");
+		return -1;
+	}
+
+	gnode = table2dt(table);
+	if (!gnode) {
+		LM_ERR("invalid table '%s'\n", table);
+		return -1;
+	}
+
+	arg = pkg_malloc(sizeof(struct check_blacklist_fs_t));

Maybe the pkg_free() has to be done in the functions you added (the kemi functions), otherwise the last change you did seems to affect the old code which was not reported to have issues. It cna be that now it frees for the kamailio.cfg native functions, when it should not happen.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2190#discussion_r363399228
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20200106/e871ac63/attachment.html>


More information about the sr-dev mailing list