[sr-dev] git:5.3:289e35cf: rtpengine: do nothing in rtpengine_manage() when used in event_route[tm:branch-failure:...]

[Daniel-Constantin Mierla]

Module: kamailio
Branch: 5.3
Commit: 289e35cff83aa0fd4fc7123e26c18dce9053bb03
URL: https://github.com/kamailio/kamailio/commit/289e35cff83aa0fd4fc7123e26c18dce9053bb03

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2020-02-25T08:39:22+01:00

rtpengine: do nothing in rtpengine_manage() when used in event_route[tm:branch-failure:...]

- avoid duplicating sdp operations

(cherry picked from commit 387de23a5c9252ee8409d378ea452bfd52e416d4)

---

Modified: src/modules/rtpengine/rtpengine.c

---

Diff:  https://github.com/kamailio/kamailio/commit/289e35cff83aa0fd4fc7123e26c18dce9053bb03.diff
Patch: https://github.com/kamailio/kamailio/commit/289e35cff83aa0fd4fc7123e26c18dce9053bb03.patch

---

diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c
index 4435825a3f..20df725d2e 100644
--- a/src/modules/rtpengine/rtpengine.c
+++ b/src/modules/rtpengine/rtpengine.c
@@ -3589,9 +3589,14 @@ rtpengine_manage(struct sip_msg *msg, const char *flags)
 	int nosdp;
 	tm_cell_t *t = NULL;
 
+	if(route_type==BRANCH_FAILURE_ROUTE) {
+		/* do nothing in branch failure event route
+		 * - delete done on transaction failure route */
+		return 1;
+	}
+
 	if (msg->cseq==NULL && ((parse_headers(msg, HDR_CSEQ_F, 0)==-1) ||
-	   (msg->cseq==NULL)))
-	{
+	   (msg->cseq==NULL))) {
 		LM_ERR("no CSEQ header\n");
 		return -1;
 	}
@@ -3599,7 +3604,7 @@ rtpengine_manage(struct sip_msg *msg, const char *flags)
 	method = get_cseq(msg)->method_id;
 
 	if (!(method==METHOD_INVITE || method==METHOD_ACK || method==METHOD_CANCEL
-	   || method==METHOD_BYE || method==METHOD_UPDATE))
+			|| method==METHOD_BYE || method==METHOD_UPDATE))
 		return -1;
 
 	if (method==METHOD_CANCEL || method==METHOD_BYE)