[sr-dev] [kamailio/kamailio] keepalive: fix initialization when using destination mod param (#2579)

Nacho G. notifications at github.com
Wed Dec 16 19:24:28 CET 2020


@NGSegovia commented on this pull request.



> +	ka_initial_dest_t * new_destination = (ka_initial_dest_t *) shm_malloc(sizeof(ka_initial_dest_t));
+	new_destination->uri.s = shm_malloc(sizeof(char) * strlen(uri));
+	new_destination->owner.s = shm_malloc(sizeof(char) * strlen(owner));
+
+	memcpy(new_destination->uri.s, uri, strlen(uri));
+	new_destination->uri.len = strlen(uri);
+
+	memcpy(new_destination->owner.s, owner, strlen(owner));
+	new_destination->owner.len = strlen(owner);
+	
+	new_destination->next = NULL;
+
+	if (ka_initial_destinations_list == NULL) {
+		ka_initial_destinations_list = new_destination;
+	} else {
+		ka_initial_dest_t *current_position = ka_initial_destinations_list;

I still see more cons than pros, but OK. Updating this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2579#discussion_r544523843
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20201216/1b427805/attachment.htm>


More information about the sr-dev mailing list