[sr-dev] git:master:a12029cd: tm: some more cleanups regarding logging (remove double log level or function)

[Henning Westerholt]

Module: kamailio
Branch: master
Commit: a12029cd2b4a9153851496fb2999b89875b5b495
URL: https://github.com/kamailio/kamailio/commit/a12029cd2b4a9153851496fb2999b89875b5b495

Author: Henning Westerholt <hw at skalatan.de>
Committer: Henning Westerholt <hw at skalatan.de>
Date: 2020-12-01T08:28:51Z

tm: some more cleanups regarding logging (remove double log level or function)

---

Modified: src/modules/tm/lock.c
Modified: src/modules/tm/t_lookup.c
Modified: src/modules/tm/t_msgbuilder.c
Modified: src/modules/tm/t_reply.c

---

Diff:  https://github.com/kamailio/kamailio/commit/a12029cd2b4a9153851496fb2999b89875b5b495.diff
Patch: https://github.com/kamailio/kamailio/commit/a12029cd2b4a9153851496fb2999b89875b5b495.patch

---

diff --git a/src/modules/tm/lock.c b/src/modules/tm/lock.c
index c06bd4c16a..ed7de0c971 100644
--- a/src/modules/tm/lock.c
+++ b/src/modules/tm/lock.c
@@ -80,8 +80,7 @@ int lock_initialize()
 			lock_set_dealloc(reply_semaphore);
 		}
 		if(i == 0) {
-			LOG(L_CRIT, "lock_initialize: could not allocate semaphore"
-						" sets\n");
+			LOG(L_CRIT, "could not allocate semaphore sets\n");
 			goto error;
 		}
 
diff --git a/src/modules/tm/t_lookup.c b/src/modules/tm/t_lookup.c
index dadfaa6b08..4ccdee7574 100644
--- a/src/modules/tm/t_lookup.c
+++ b/src/modules/tm/t_lookup.c
@@ -1067,8 +1067,7 @@ int t_check_msg( struct sip_msg* p_msg , int *param_branch )
 			if (cfg_get(tm, tm_cfg, tm_aggregate_auth) &&
 					(p_msg->REPLY_STATUS==401 || p_msg->REPLY_STATUS==407)){
 				if (parse_headers(p_msg, HDR_EOH_F,0)==-1){
-					LM_WARN("WARNING: the reply cannot be "
-							"completely parsed\n");
+					LM_WARN("the reply cannot be completely parsed\n");
 					/* try to continue, via1 & cseq are checked below */
 				}
 			}else if ( parse_headers(p_msg, HDR_VIA1_F|HDR_CSEQ_F|HDR_CALLID_F,
diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c
index cda84b6f5d..47f94c1697 100644
--- a/src/modules/tm/t_msgbuilder.c
+++ b/src/modules/tm/t_msgbuilder.c
@@ -484,7 +484,7 @@ char *build_local_reparse(tm_cell_t *Trans,unsigned int branch,
 				/* final (end-of-headers) CRLF */
 				append_str(d, CRLF, CRLF_LEN);
 				*len = d - cancel_buf;
-				/* LOG(L_DBG, "DBG: build_local: %.*s\n", *len, cancel_buf); */
+				/* LOG(L_DBG, "%.*s\n", *len, cancel_buf); */
 				return cancel_buf;
 
 			default:
diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c
index 481a4a00f8..51b669f776 100644
--- a/src/modules/tm/t_reply.c
+++ b/src/modules/tm/t_reply.c
@@ -1666,8 +1666,7 @@ int t_retransmit_reply( struct cell *t )
 	 * the chances for this increase a lot.
 	 */
 	if (!t->uas.response.dst.send_sock) {
-		LOG(L_WARN, "WARNING: t_retransmit_reply: "
-			"no resolved dst to retransmit\n");
+		LOG(L_WARN, "no resolved dst to retransmit\n");
 		return -1;
 	}
 
@@ -1677,14 +1676,13 @@ int t_retransmit_reply( struct cell *t )
 	LOCK_REPLIES( t );
 
 	if (!t->uas.response.buffer) {
-		DBG("DBG: t_retransmit_reply: nothing to retransmit\n");
+		DBG("nothing to retransmit\n");
 		goto error;
 	}
 
 	len=t->uas.response.buffer_len;
 	if ( len==0 || len>BUF_SIZE )  {
-		DBG("DBG: t_retransmit_reply: "
-			"zero length or too big to retransmit: %d\n", len);
+		DBG("zero length or too big to retransmit: %d\n", len);
 		goto error;
 	}
 	memcpy( b, t->uas.response.buffer, len );