[sr-dev] [kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)

[ng-voice GmbH]

Sorry for the delay. Due to the Corona virus, the access to the Lab is a limited. In fact, it's good business for our Lab-Network vendors, as we had to replicate the Lab to various colleagues at home... ;-)

However, the result of testing is exactly as expected. This is the NOTIFY for the SUBSCRIBE from the UE to the S-CSCF (this one is correct):

```
2020/04/07 14:56:47.851519 172.18.0.24:6060 -> 192.168.178.92:5060
NOTIFY sip:40e02947-53d8-48c3-a1b2-eca3dd2635fd at 192.168.4.6:42923 SIP/2.0
Via: SIP/2.0/UDP 172.18.0.24:6060;branch=z9hG4bK1d7b.c2da92c5000000000000000000000000.0
To: <tel:+494046899711>;tag=3291254491
From: <tel:+494046899711>;tag=ee326f8ce5448eb29429c3445faa64d5-ae1c
CSeq: 70029013 NOTIFY
Call-ID: 3291254482_2340697020 at 192.168.4.6
Route: <sip:mo at 192.168.178.92;r2=on;lr=on;ftag=3291254491>, <sip:mo at 192.168.178.92:5062;r2=on;lr=on;ftag=3291254491>
Content-Length: 1779
User-Agent: Kamailio S-CSCF
Contact: <sip:scscf-1.ims.mnc001.mcc001.3gppnetwork.org>
Event: reg
Max-Forwards: 70
Subscription-State: active;expires=600000
Content-Type: application/reginfo+xml

<?xml version="1.0"?>
<reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="2" state="full">
 <registration aor="tel:+494046899711" id="0x7f8844b8f5a8" state="active">
  <contact id="0x7f8844b9e9e0" state="active" event="registered" expires="600000">
   <uri>sip:40e02947-53d8-48c3-a1b2-eca3dd2635fd at 192.168.4.6:42923</uri>
  <unknown-param name="+sip.instance">"<urn:gsma:imei:86153804-193985-0>"</unknown-param>
  <unknown-param name="video"></unknown-param>
  <unknown-param name="+g.3gpp.smsip"></unknown-param>
  <unknown-param name="+g.3gpp.icsi-ref">""</unknown-param>
  </contact>
 </registration>
 <registration aor="sip:494046899711 at ims.mnc001.mcc001.3gppnetwork.org" id="0x7f8844b8faa0" state="active">
  <contact id="0x7f8844b9e9e0" state="active" event="registered" expires="600000">
   <uri>sip:40e02947-53d8-48c3-a1b2-eca3dd2635fd at 192.168.4.6:42923</uri>
  <unknown-param name="+sip.instance">"<urn:gsma:imei:86153804-193985-0>"</unknown-param>
  <unknown-param name="video"></unknown-param>
  <unknown-param name="+g.3gpp.smsip"></unknown-param>
  <unknown-param name="+g.3gpp.icsi-ref">""</unknown-param>
  </contact>
 </registration>
 <registration aor="sip:+494046899711 at ims.mnc001.mcc001.3gppnetwork.org" id="0x7f8844b8ffa8" state="active">
  <contact id="0x7f8844b9e9e0" state="active" event="registered" expires="600000"
[kamailio-notify-bug.zip](https://github.com/kamailio/kamailio/files/4445391/kamailio-notify-bug.zip)

>
   <uri>sip:40e02947-53d8-48c3-a1b2-eca3dd2635fd at 192.168.4.6:42923</uri>
  <unknown-param name="+sip.instance">"<urn:gsma:imei:86153804-193985-0>"</unknown-param>
  <unknown-param name="video"></unknown-param>
  <unknown-param name="+g.3gpp.smsip"></unknown-param>
  <unknown-param name="+g.3gpp.icsi-ref">""</unknown-param>
  </contact>
 </registration>
</reginfo>

```
But for the P-CSCF to the S-CSCF, we are missing significant parts, which makes the NOTIFY invalid:

```
2020/04/07 14:56:47.747234 172.18.0.24:6060 -> 192.168.178.92:5060
NOTIFY sip:pcscf-int-1.ims.mnc001.mcc001.3gppnetwork.org SIP/2.0
Via: SIP/2.0/UDP 172.18.0.24:6060;branch=z9hG4bK6f36.eb2f0cc3000000000000000000000000.0
To: <sip:pcscf-int-1.ims.mnc001.mcc001.3gppnetwork.org>;tag=bbaebbb44e94e479868b46460b1d800b-d988
From: <sip:494046899711 at ims.mnc001.mcc001.3gppnetwork.org>;tag=ee326f8ce5448eb29429c3445faa64d5-ae1c
CSeq: 13 NOTIFY
Call-ID: 7fb844aa6636e93a-173 at 192.168.178.92
Content-Length: 450
User-Agent: Kamailio S-CSCF
Contact: <sip:scscf-1.ims.mnc001.mcc001.3gppnetwork.org>
Event: reg
Max-Forwards: 70
Subscription-State: active;expires=3700
Content-Type: application/reginfo+xml

<?xml version="1.0"?>
<reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="2" state="full">
 <registration aor="tel:+494046899711" id="0x7f8844b8f5a8" state="active">
 </registration>
 <registration aor="sip:494046899711 at ims.mnc001.mcc001.3gppnetwork.org" id="0x7f8844b8faa0" state="active">
 </registration>
 <registration aor="sip:+494046899711 at ims.mnc001.mcc001.3gppnetwork.org" id="0x7f8844b8ffa8" state="active">
 </registration>
</reginfo>

```

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2246#issuecomment-610443138
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20200407/6ea86e85/attachment.html>